Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated OpenAPI and OpenAPI UI doc for 4.0 #7823

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Updated OpenAPI and OpenAPI UI doc for 4.0 #7823

merged 2 commits into from
Oct 18, 2023

Conversation

tjquinno
Copy link
Member

Description

Resolves #6457

Note that there are not yet any updates to the generator pages because we have not updated the generator to work with 4.0 yet.

@tjquinno tjquinno self-assigned this Oct 17, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 17, 2023
ljamen
ljamen reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small changes and typos.

docs/includes/openapi/openapi-ui.adoc Outdated Show resolved Hide resolved
docs/includes/openapi/openapi-ui.adoc Show resolved Hide resolved
docs/includes/openapi/openapi.adoc Show resolved Hide resolved
docs/se/openapi/openapi-ui.adoc Outdated Show resolved Hide resolved
docs/se/openapi/openapi-ui.adoc Outdated Show resolved Hide resolved
docs/se/openapi/openapi-ui.adoc Outdated Show resolved Hide resolved
docs/se/openapi/openapi.adoc Outdated Show resolved Hide resolved
@ljamen ljamen self-requested a review October 18, 2023 15:33
ljamen
ljamen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes addresses - LGTM

@tjquinno tjquinno merged commit 7b51872 into helidon-io:main Oct 18, 2023
12 checks passed
@tjquinno tjquinno deleted the 4.x-openapi-doc-update branch October 18, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@barchetta barchetta Awaiting requested review from barchetta

Assignees

@tjquinno tjquinno

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjquinno @ljamen