Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Enable disabled TCKs #7781

Merged
merged 39 commits into from
Dec 15, 2023
Merged

4.x: Enable disabled TCKs #7781

merged 39 commits into from
Dec 15, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Oct 12, 2023 •
edited
Loading

Description

Enabling the disabled tests of TCK.

Relates to #6799

Some points to consider, mostly Restful TCK made the biggest headaches.

  • Restful TCK: CatchAllMapperException it not enabled in Helidon, but stll exists for explicit usage and you will find some tests adding it explicitly. This could require further analysis in other issue, because it looks some modules requires to have the default mapper.
  • Restful TCK: There were many issues with the paths, so I reworked it a bit.
  • Restful TCK: Arquillian module is a bit tricky to deal with the restful tests. I created a TCK Challenge to simplify it.
  • Other changes are punctual fixes required for the TCKs.

Documentation

N/A

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 12, 2023
@jbescos jbescos marked this pull request as draft October 12, 2023 09:57
@jbescos jbescos force-pushed the tckDisabled branch 7 times, most recently from a6101d9 to f2c1543 Compare October 12, 2023 14:47
@jbescos
Enable disabled TCKs
8fb7b06 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Remove unnecessary HelidonContainerConfiguration property
8935601 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Fixing restfull tcks
b9cf14d 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Revert "Remove unnecessary HelidonContainerConfiguration property"
66f114f 
This reverts commit 8935601.

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Include explicit rest apps
6e7368e 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos jbescos force-pushed the tckDisabled branch 4 times, most recently from 3e95e1b to 2eb101a Compare October 18, 2023 08:21
@jbescos
Defend agains 1+ deployments
7bfe1e7 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Fix matrix TCKs
bba4aa7 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos jbescos force-pushed the tckDisabled branch 7 times, most recently from 5bbae76 to 839c5e7 Compare October 27, 2023 11:40
@jbescos
CDI sigtest
9027d19 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Enabled disabled test
4b65eca 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Fix metrix HelloWorldTest
70b7223 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@spericas
Copy link
Member

@jbescos Could you provide a description above of why all these changes are needed? For example, the catch all exception handlers, the changes to files under helidon/integrations, etc. I'm missing some context here ... a bullet list summarizing the changes with some rationale would be helpful.

@jbescos
Copy link
Member Author

jbescos commented Dec 13, 2023

@spericas my bad. I have added them.

@jbescos
Improvements in ServerSseTest
a4e968a 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Unify CatchAllExceptionMapper
76e6609 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
spericas
spericas approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR's description with the latest changes related to the CatchAllExceptionMapper.

@jbescos
Copy link
Member Author

jbescos commented Dec 15, 2023

Please update the PR's description with the latest changes related to the CatchAllExceptionMapper.

Done, thank you for the review @spericas

@jbescos jbescos merged commit e19d535 into helidon-io:main Dec 15, 2023
12 checks passed
@jbescos jbescos mentioned this pull request Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@ljnelson ljnelson Awaiting requested review from ljnelson

@danielkec danielkec Awaiting requested review from danielkec

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@jbescos jbescos

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbescos @spericas