[4.x] Switches default JPA CDI portable extension to PersistenceExtension from JpaExtension #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom JpaExtension Signed-off-by: Laird Nelson <[email protected]>
ljnelson
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Laird Nelson <[email protected]>
…nfoBean before it is placed into service; adjusts Hibernate integration to make use of this facility Signed-off-by: Laird Nelson <[email protected]>
…ernate-cdi Signed-off-by: Laird Nelson <[email protected]>
…JTA association would have its autoCommit status set to false in certain situations Signed-off-by: Laird Nelson <[email protected]>
|
@tjquinno added you as reviewer since you were kind enough to review the "new machinery" back in the day. Obviously check the Github actions etc. and if they're borked don't bother wasting your time; I'll fix whatever breaks first. Any early eyes-on from you would be great. |
Signed-off-by: Laird Nelson <[email protected]>
|
Related to #4928, and may (finally) fix it. |
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 17, 2023
…sion from JpaExtension (helidon-io#7719) * Switches default JPA CDI portable extension to PersistenceExtension from JpaExtension Signed-off-by: Laird Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "turns on" the "new" JPA machinery that has been lying somewhat dormant in Helidon since 3.x. The "old" machinery remains, since the new machinery is a very different approach, and there may be production cases where the old machinery needs to be switched back on in case old behavior was being relied upon.
This PR also adds deprecation notices to various classes (most of which are internal anyway but it's good practice).
This PR also ensures that any usage of the
CDISEJtaPlatformin combination with the ("new machinery")PersistenceExtensionwill cause the appropriate Hibernate-specific connection handling policy to be in effect, even if it isn't present in apersistence.xml.This PR also fixes a setting-the-
autoCommit-property-on-a-Connectionbug that may be responsible for blocking #7448. We'll see.Documentation impact: none.