-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Native image update #7711
Merged
Merged
4.x: Native image update #7711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Java 21 - latest version - replace artifact id - remove initialize-at-build-time in SE
tomas-langer
added
graal
dependencies
Pull requests that update a dependency file
native-image
4.x
Version 4.x
labels
Oct 3, 2023
tomas-langer
requested review from
danielkec,
romain-grecourt,
barchetta and
arjav-desai
October 3, 2023 19:24
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Oct 3, 2023
Add kotlin dependency to resolve modularized failure
Checked Kafka connector and few more changes are needed tomas-langer/pull/4 |
tvallin
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that a Main.java
class is generated for both SE and MP, it makes sense to have a Main.java.mustache
under archetype/common
. But this change can be made in another PR. See #7714
Kafka connector native image updates
danielkec
approved these changes
Oct 4, 2023
tvallin
approved these changes
Oct 4, 2023
barchetta
approved these changes
Oct 4, 2023
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 17, 2023
* Native image update - Java 21 - latest version - replace artifact id - remove initialize-at-build-time in SE - doc fix - Updates to graalvm github action - Upgrade jar plugin to honor main class attribute for modules - Add main class to modularized test - Add kotlin dependency to resolve modularized failure - Native packaging test fixed. - Fix archetypes to work with new jar plugin - Kafka connector native image updates --------- Co-authored-by: Daniel Kec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
dependencies
Pull requests that update a dependency file
graal
native-image
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7683
Had to introduce a custom main class to modularized projects (e.g. to all MP archetypes), as the jar plugin requires a main class that is in the package of the module (it now adds the main class to manifest, and as an attribute of the
module-info.java
to make the modules runnable).Merged changes for Kafka from @danielkec
Documentation
I have updated the documentation for MP to mention new requirements.
In addtion this may influence existing users of Helidon SE, as we used to have build time initialization for almost everything. Now we have aligned with GraalVM guidelines, and we do not do it for SE (except for classes where it is a requirements).