Make SE metrics default scope application instead of nothing #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…defaulted to application for a meter that the test checks for
barchetta
reviewed
Sep 25, 2023
… to reflect changes in 4.x request processing
barchetta
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7658
Originally, the neutral Helidon metrics API (SE) assigned no default scope to new meters unless the developer set the default scope to a value. This PR changes that so the "default default" scope is
applicationinstead of nothing.Developers can still assign any specific scope to an individual meter when registering it and can also assign a different default scope (or clear the "default default" scope) using the
ScopingConfigwithinMetricsConfig.Documentation
Doc impact: will be included in the metrics doc rewrite #7381