-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: metrics and openapi endpoints should be authorized by default #7572
Merged
romain-grecourt
merged 3 commits into
helidon-io:main
from
tvallin:metric-openapi-authorized
Sep 27, 2023
Merged
4.x: metrics and openapi endpoints should be authorized by default #7572
romain-grecourt
merged 3 commits into
helidon-io:main
from
tvallin:metric-openapi-authorized
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvallin
added
enhancement
New feature or request
metrics
security
open-api
4.x
Version 4.x
labels
Sep 12, 2023
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Sep 12, 2023
tvallin
changed the title
4.x: metrics and openapi endpoints shoudl be authorized by default
4.x: metrics and openapi endpoints should be authorized by default
Sep 12, 2023
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
September 14, 2023 10:13
a0b0485
to
0265f44
Compare
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
September 19, 2023 14:51
bcc9a40
to
34e6a49
Compare
tomas-langer
previously requested changes
Sep 21, 2023
...ervice-common/src/test/java/io/helidon/webserver/servicecommon/HelidonSecureFeatureTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
...ics/src/test/java/io/helidon/webserver/tests/observe/metrics/ObserveMetricsSecurityTest.java
Outdated
Show resolved
Hide resolved
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
September 26, 2023 14:39
12700ea
to
741c5e0
Compare
romain-grecourt
dismissed
tomas-langer’s stale review
September 27, 2023 15:55
Changes have been made
tvallin
force-pushed
the
metric-openapi-authorized
branch
from
September 27, 2023 16:00
afebe02
to
edfcfec
Compare
romain-grecourt
previously approved these changes
Sep 27, 2023
Signed-off-by: tvallin <[email protected]>
romain-grecourt
force-pushed
the
metric-openapi-authorized
branch
from
September 27, 2023 18:06
edfcfec
to
aab69ec
Compare
romain-grecourt
previously approved these changes
Sep 27, 2023
Include a fix to #7510 |
Signed-off-by: tvallin <[email protected]>
romain-grecourt
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
enhancement
New feature or request
metrics
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
open-api
security
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #7439
Documentation
no impact