[3.x] - Simple to Batch Span exporter #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Aleksandrov <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
requested changes
Aug 22, 2023
| @@ -299,6 +306,11 @@ public JaegerTracerBuilder config(Config config) { | |||
|
|
|||
| config.get("global").asBoolean().ifPresent(this::registerGlobal); | |||
|
|
|||
| config.get("exporter-timeout-millis").asLong().ifPresent(it -> exporterTimeout(Duration.ofMillis(it))); | |||
There was a problem hiding this comment.
switch to Duration instead of millis - so the property should be exporter-timeout (same for schedule delay)
| @@ -462,7 +510,12 @@ public Tracer build() { | |||
| Resource serviceName = Resource.create(attributesBuilder.build()); | |||
| OpenTelemetry ot = OpenTelemetrySdk.builder() | |||
| .setTracerProvider(SdkTracerProvider.builder() | |||
| .addSpanProcessor(SimpleSpanProcessor.create(exporter)) | |||
| .addSpanProcessor(BatchSpanProcessor.builder(exporter) | |||
There was a problem hiding this comment.
It would be better to have a choice than a hardcoded option. Esp. for testing the SimpleSpanProcessor is better.
So maybe introduce span-processor-type that would be simple or batch (not sure if other supported).
Then use the one chosen (and we can have batch as default, if that is better for production)
Signed-off-by: Dmitry Aleksandrov <[email protected]>
Signed-off-by: Dmitry Aleksandrov <[email protected]>
tomas-langer
requested changes
Aug 23, 2023
| * @return updated builder | ||
| */ | ||
| @ConfiguredOption(key = "span-processor-type", value = "batch") | ||
| public JaegerTracerBuilder spanProcessorType(String spanProcessorType) { |
There was a problem hiding this comment.
You should use the SpanProcessorType as the parameter here.
Signed-off-by: Dmitry Aleksandrov <[email protected]>
Signed-off-by: Dmitry Aleksandrov <[email protected]>
Signed-off-by: Dmitry Aleksandrov <[email protected]>
Signed-off-by: Dmitry Aleksandrov <[email protected]>
tomas-langer
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves internal request to switch to Batch Span Exporter to Jaeger tracer. This should significantly improve performance.
Doc impact: new config properties