Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change heap functions to get current memory usage #7404

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

edthorne
Copy link

Description

Resolves #7374 by providing inline function to get current heap memory metrics rather than a static snapshot of the heap memory metrics.

Documentation

None

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 20, 2023
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edthorne Thanks for the issue and the PR. (Although there is no test with the PR, I assume you have verified that your change allows the reported values to actually change.)

Maybe you already noticed, but this problem does not occur in 2.x. And I am actively working on the metrics code in 4.x and will incorporate this fix into those changes. So there's no need to create other issues for this problem in other releases.

@tjquinno tjquinno merged commit 18216f1 into helidon-io:helidon-3.x Aug 25, 2023
@edthorne edthorne deleted the helidon-3.x-7374 branch September 7, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM Heap metrics never change
2 participants