4.x: Media Context and streaming #7396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <[email protected]>
Signed-off-by: Tomas Langer <[email protected]>
…ffering in memory. Fixes of issues uncovered by this change. Signed-off-by: Tomas Langer <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
requested review from
Verdent,
danielkec,
romain-grecourt and
spericas
danielkec
approved these changes
Aug 17, 2023
Verdent
requested changes
Aug 17, 2023
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Show resolved
Hide resolved
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Show resolved
Hide resolved
Verdent
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Media writers now correctly handle streaming where needed, without buffering in memory.
Fixes of issues uncovered by this change.
This impacts custom Media supports only, the API remains the same.
Fixed issues that were uncovered (as now we use streaming a bit more).
Resolves #7006
Moved to M2 milestone, as this resolves some bigger issues (such as 100-Continue handling)