Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nima Proxy TODOs #7168

Closed
wants to merge 3 commits into from
Closed

Nima Proxy TODOs #7168

wants to merge 3 commits into from

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jul 11, 2023 •
edited
Loading

#7143

  • Support it in HTTP 2
  • Support Proxy authentication
  • Support SOCKS ??
  • Some proxies respond with HTTP 1.0 protocol and Http1StatusParser will fail
  • HTTP CONNECT should specify the host:port of the remote (not the proxy)
    In my opinion, it makes no sense because the header HOST is mandatory and it contains the remote host:port, but you can try it by yourself configuring a proxy in your browser. For example when you visit youtube you will see the next:
CONNECT www.youtube.com:443 HTTP/1.1
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0
Proxy-Connection: keep-alive
Connection: keep-alive
Host: www.youtube.com:443

Some proxies could not work properly if the CONNECT is not set correctly.

@jbescos
CONNECT host:port is wrong
938fade 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 11, 2023
@jbescos jbescos requested review from tomas-langer and Verdent July 11, 2023 12:04
@jbescos jbescos changed the title CONNECT host:port is wrong Nima Proxy TODOs Jul 13, 2023
@jbescos jbescos force-pushed the issue7143_connect branch 2 times, most recently from 2301f51 to 27f12a9 Compare July 13, 2023 06:48
@jbescos
Allow HTTP 1.0 responses
79bef69 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos jbescos force-pushed the issue7143_connect branch 3 times, most recently from b6d0fad to 7629e73 Compare July 13, 2023 12:03
@jbescos
Refactoring for usage in http2
e9738f7 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos jbescos force-pushed the issue7143_connect branch from 7629e73 to e9738f7 Compare July 13, 2023 13:20
tomas-langer
tomas-langer requested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased once #7255 is merged, as this will be in conflict

@jbescos
Copy link
Member Author

jbescos commented Aug 1, 2023

Moving PR to here: #7287

@jbescos jbescos closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer requested changes

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@jbescos jbescos

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbescos @tomas-langer