Remove metrics app registry clear-out code from metrics extension; add doc #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribing correct way to deal with metrics from extensions
tjquinno
requested review from
ljnelson,
spericas,
ljamen and
Geetha-Savithriamma
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4656
Prior to this PR, the metrics CDI extension cleared the application metrics registry late in the CDI life cycle. Metrics registered earlier during start-up by developer code (such as from a developer-written extension) would disappear.
The clear-out code is needed to allow the TCK tests to work correctly.
This PR does two main things:
RuntimeStartCDI event.Helidon will not prevent users from registering metrics prematurely. But the metrics system might not behave as configured if they do. The doc additions explain this.