Adds Nima WebClient Shortcuts for media support #6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
added
webclient
media-support
oracle-contributor-agreement
bot
added
the
OCA Verified
klustria
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Not really a MediaContext expert, but in comparison to the Server implementation, the changes seem to look fine to me. The only comment I may have, and maybe this is more of a question... is it possible to add a test on this in nima/tests/integration/webclient to test out new shortcut like addMediaSupport like below:
WebClient webClient = WebClient.builder()
...
.addMediaSupport(JsonpSupport.create())
...
.build();
Signed-off-by: Laird Nelson <[email protected]>
klustria
previously approved these changes
Jun 13, 2023
romain-grecourt
previously approved these changes
Jun 13, 2023
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to do the equivalent of what #6564 does on the server side with as few changes as possible. This is not my area at all so please do let me know what I've done wrong.