-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder updates #6710
Merged
Merged
Builder updates #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validate, yet updates values from configuration. Repeatable is set to false by default on ConfigBean Support for Duration default value in Builders
tomas-langer
added
4.x
Version 4.x
declarative
Helidon Declarative
builder
Related to the builder support
labels
Apr 27, 2023
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Apr 27, 2023
trentjeff
reviewed
Apr 27, 2023
...ilder-config/src/main/java/io/helidon/builder/config/spi/GeneratedConfigBeanBuilderBase.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Apr 27, 2023
...untime/src/main/java/io/helidon/pico/configdriven/runtime/DefaultPicoConfigBeanRegistry.java
Show resolved
Hide resolved
trentjeff
reviewed
Apr 27, 2023
...untime/src/main/java/io/helidon/pico/configdriven/runtime/DefaultPicoConfigBeanRegistry.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Apr 27, 2023
pico/tests/resources-pico/src/test/resources/expected/ximpl-interceptor._java_
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Apr 27, 2023
pico/tools/src/main/java/io/helidon/pico/tools/CustomAnnotationTemplateRequest.java
Outdated
Show resolved
Hide resolved
trentjeff
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
builder
Related to the builder support
declarative
Helidon Declarative
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6709
Resolves #6712
Changed default prefix to
""
and default suffix to"Default"
for builders.Support for config(Config) method on generated builders that does not validate, yet updates values from configuration.
Repeatable is set to false by default on ConfigBean
Support for Duration default value in Builders