-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for different propagators for Jaeger OpenTelemetry integration. #6586
Merged
tomas-langer
merged 5 commits into
helidon-io:main
from
tomas-langer:6574-jaeger-propagation
Apr 13, 2023
Merged
Support for different propagators for Jaeger OpenTelemetry integration. #6586
tomas-langer
merged 5 commits into
helidon-io:main
from
tomas-langer:6574-jaeger-propagation
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Apr 11, 2023
bogedal
reviewed
Apr 11, 2023
tracing/jaeger/src/main/java/io/helidon/tracing/jaeger/JaegerTracerBuilder.java
Outdated
Show resolved
Hide resolved
bogedal
previously approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danielkec
reviewed
Apr 12, 2023
tracing/jaeger/src/test/java/io/helidon/tracing/jaeger/JaegerTracerBuilderTest.java
Show resolved
Hide resolved
danielkec
approved these changes
Apr 12, 2023
Any known timeline for the release of this in version 3.2.1 ? |
tomas-langer
added a commit
to tomas-langer/helidon
that referenced
this pull request
Apr 13, 2023
…n. (helidon-io#6586) * Support for different propagators for Jaeger OpenTelemetry integration. * Added tests to validate the correct propagators are added (cherry picked from commit f5bf1ff) Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
added a commit
that referenced
this pull request
Apr 17, 2023
…n. (#6586) (#6611) * Support for different propagators for Jaeger OpenTelemetry integration. * Added tests to validate the correct propagators are added (cherry picked from commit f5bf1ff) Signed-off-by: Tomas Langer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6574
A support for compatibilty with 2.x - we now support Jaeger, B3, and W3C propagators, Jaeger is the default.
Backport issue for 3.x: #6587
There is no need to backport to 2.x, as it is based on OpenTracing