Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New document that describes Nima's SSE APIs #6332

Merged
merged 4 commits into from
Mar 8, 2023
Merged

New document that describes Nima's SSE APIs #6332

merged 4 commits into from
Mar 8, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Mar 1, 2023 •
edited by danielkec
Loading

New document that describes the server and the client APIs in Nima for server-sent events.

Part of #5666

@spericas spericas added docs 4.x Version 4.x labels Mar 1, 2023
@spericas spericas added this to the 4.0.0 milestone Mar 1, 2023
@spericas spericas requested a review from ljamen March 1, 2023 21:25
@spericas spericas self-assigned this Mar 1, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 1, 2023
@danielkec danielkec mentioned this pull request Mar 2, 2023
Closed
2 tasks
ljamen
ljamen reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, We should probably discuss Nima branding with the accented i across all new Nima docs. Níma

docs/nima/sse/sse.adoc Outdated Show resolved Hide resolved
docs/nima/sse/sse.adoc Outdated Show resolved Hide resolved
docs/nima/sse/sse.adoc Outdated Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
docs/nima/sse/sse.adoc Show resolved Hide resolved
@ljamen ljamen mentioned this pull request Mar 2, 2023
Closed
7 tasks
@spericas spericas requested a review from ljamen March 2, 2023 20:09
ljamen
ljamen previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spericas added 3 commits March 7, 2023 13:02
@spericas
New document that describes the server and the client APIs in Nima fo…
2024c71 
…r server-sent events.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas
Improved code indentation.
197d525 
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas
Updates based on PR feedback.
289fef9 
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas
Updated sitegen.yaml
44cf279 
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@ljamen ljamen merged commit ca4638e into helidon-io:main Mar 8, 2023
@spericas spericas mentioned this pull request Mar 8, 2023
Closed
This was referenced Mar 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen approved these changes

Assignees

@spericas spericas

Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @ljamen