-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Configuration fixes #6145
Merged
Merged
4.x: Configuration fixes #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow unresolved key references (configurable) - config created from another config honors node types
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Feb 10, 2023
A developer should be able to set the fail-on-missing-key-reference behavior programmatically as well as in the config file. |
… - aligned with value resolving filter Builder methods added for key resolving and value resolving "fail on missing reference"
tjquinno
approved these changes
Feb 10, 2023
tomas-langer
added a commit
to tomas-langer/helidon
that referenced
this pull request
Feb 10, 2023
* Configuration fixes: - allow unresolved key references (configurable) - config created from another config honors node types - Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter - Config.Builder methods added for key resolving and value resolving "fail on missing reference" (cherry picked from commit aa26ec8) Signed-off-by: Tomas Langer <[email protected]>
barchetta
pushed a commit
that referenced
this pull request
Feb 10, 2023
* 4.x: Configuration fixes (#6145) - allow unresolved key references (configurable) - config created from another config honors node types - Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter - Config.Builder methods added for key resolving and value resolving "fail on missing reference" Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
added a commit
to tomas-langer/helidon
that referenced
this pull request
Feb 12, 2023
- allow unresolved key references (configurable) - config created from another config honors node types - Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter - Config.Builder methods added for key resolving and value resolving "fail on missing reference" Signed-off-by: Tomas Langer <[email protected]>
Closed
tomas-langer
added a commit
that referenced
this pull request
Feb 13, 2023
* 2.x: Configuration fixes (#6145) (#6150) - allow unresolved key references (configurable) - config created from another config honors node types - Key resolving does not fail by default when reference cannot be found - aligned with value resolving filter - Config.Builder methods added for key resolving and value resolving "fail on missing reference" - Fixed switch statement, too new java feature... Signed-off-by: Tomas Langer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
bug
Something isn't working
config
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6102
Config.Builder
methods to control "fail on missing reference" behavior for both key resolving and value resolving