4.x: Upgrade Weld to 5.x #5815 #5830

jbescos · 2023-01-11T12:07:58Z

Relates to #5815 and #5821 (only the part of upgrading Jersey)

currently one tck is failing. The test expect to fail with the next, but it is not failing. I set it as draft meanwhile I investigate further.

ERROR] org.eclipse.microprofile.config.tck.broken.ConfigPropertiesMissingPropertyInjectionTest.arquillianBeforeClass  Time elapsed: 0.041 s  <<< FAILURE!
org.jboss.arquillian.container.spi.client.container.DeploymentException: Deployment failure!
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.lambda$deploy$0(HelidonDeployableContainer.java:211)
	at java.base/java.util.Optional.map(Optional.java:260)
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.deploy(HelidonDeployableContainer.java:210)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:151)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:118)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.executeOperation(ContainerDeployController.java:239)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deploy(ContainerDeployController.java:118)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createDeploymentContext(ContainerDeploymentContextHandler.java:71)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createContainerContext(ContainerDeploymentContextHandler.java:54)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.container.impl.client.container.DeploymentExceptionHandler.verifyExpectedExceptionDuringDeploy(DeploymentExceptionHandler.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:92)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:77)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachDeployment(ContainerDeployController.java:232)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachManagedDeployment(ContainerDeployController.java:212)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deployManaged(ContainerDeployController.java:77)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.test.impl.client.ContainerEventController.execute(ContainerEventController.java:96)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.test.impl.TestContextHandler.createClassContext(TestContextHandler.java:83)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.test.impl.TestContextHandler.createSuiteContext(TestContextHandler.java:69)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.test.impl.EventTestRunnerAdaptor.beforeClass(EventTestRunnerAdaptor.java:89)
	at org.jboss.arquillian.testng.Arquillian.arquillianBeforeClass(Arquillian.java:99)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:65)
	at org.testng.internal.invokers.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:381)
	at org.testng.internal.invokers.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:319)
	at org.testng.internal.invokers.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:178)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:122)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:808)
	at org.testng.TestRunner.run(TestRunner.java:603)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:429)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:423)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:383)
	at org.testng.SuiteRunner.run(SuiteRunner.java:326)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1249)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
	at org.testng.TestNG.runSuites(TestNG.java:1092)
	at org.testng.TestNG.run(TestNG.java:1060)
	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:284)
	at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75)
	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:119)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: jakarta.enterprise.inject.spi.DeploymentException: Cannot find configuration key customer.nationality for field public java.lang.String org.eclipse.microprofile.config.tck.broken.ConfigPropertiesBeanMissingProperty.nationality
	at io.helidon.microprofile.config.FieldSetter.validate(FieldSetter.java:164)
	at io.helidon.microprofile.config.ConfigBeanDescriptor.lambda$validate$1(ConfigBeanDescriptor.java:111)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at io.helidon.microprofile.config.ConfigBeanDescriptor.validate(ConfigBeanDescriptor.java:111)
	at io.helidon.microprofile.config.ConfigBeanDescriptor.create(ConfigBeanDescriptor.java:106)
	at io.helidon.microprofile.config.ConfigCdiExtension.processAnnotatedType(ConfigCdiExtension.java:131)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.weld.injection.StaticMethodInjectionPoint.invoke(StaticMethodInjectionPoint.java:95)
	at org.jboss.weld.injection.StaticMethodInjectionPoint.invoke(StaticMethodInjectionPoint.java:85)
	at org.jboss.weld.injection.MethodInvocationStrategy$SimpleMethodInvocationStrategy.invoke(MethodInvocationStrategy.java:168)
	at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:330)
	at org.jboss.weld.event.ExtensionObserverMethodImpl.sendEvent(ExtensionObserverMethodImpl.java:123)
	at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:308)
	at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:286)
	at org.jboss.weld.bootstrap.events.ContainerLifecycleEvents.fireProcessAnnotatedType(ContainerLifecycleEvents.java:207)
	at org.jboss.weld.bootstrap.events.ContainerLifecycleEvents.fireProcessAnnotatedType(ContainerLifecycleEvents.java:176)
	at org.jboss.weld.bootstrap.BeanDeployer.processAnnotatedTypes(BeanDeployer.java:166)
	at org.jboss.weld.bootstrap.BeanDeployment.createTypes(BeanDeployment.java:219)
	at org.jboss.weld.bootstrap.WeldStartup.startInitialization(WeldStartup.java:426)
	at org.jboss.weld.bootstrap.WeldBootstrap.startInitialization(WeldBootstrap.java:79)
	at io.helidon.microprofile.cdi.HelidonContainerImpl.init(HelidonContainerImpl.java:204)
	at io.helidon.common.context.Contexts.runInContext(Contexts.java:137)
	at io.helidon.microprofile.cdi.HelidonContainerImpl.initInContext(HelidonContainerImpl.java:135)
	at io.helidon.microprofile.cdi.HelidonContainerImpl.create(HelidonContainerImpl.java:127)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.lambda$createContainer$2(BuildTimeInitializer.java:63)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.accessContainer(BuildTimeInitializer.java:72)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.createContainer(BuildTimeInitializer.java:62)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.lambda$get$0(BuildTimeInitializer.java:46)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.accessContainer(BuildTimeInitializer.java:72)
	at io.helidon.microprofile.cdi.BuildTimeInitializer.get(BuildTimeInitializer.java:44)
	at io.helidon.microprofile.cdi.ContainerInstanceHolder.fromBuildTimeInitializer(ContainerInstanceHolder.java:65)
	at io.helidon.microprofile.cdi.ContainerInstanceHolder.lambda$get$1(ContainerInstanceHolder.java:56)
	at io.helidon.microprofile.cdi.ContainerInstanceHolder.access(ContainerInstanceHolder.java:91)
	at io.helidon.microprofile.cdi.ContainerInstanceHolder.get(ContainerInstanceHolder.java:53)
	at io.helidon.microprofile.cdi.HelidonContainer.instance(HelidonContainer.java:48)
	at io.helidon.microprofile.server.Server$Builder.build(Server.java:180)
	at io.helidon.microprofile.arquillian.ServerRunner.start(ServerRunner.java:70)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.startServer(HelidonDeployableContainer.java:317)
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.deploy(HelidonDeployableContainer.java:195)
	... 88 more

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos · 2023-01-18T07:13:30Z

The issue is that test ConfigPropertiesMissingPropertyInjectionTest contains a bean ConfigPropertiesBeanMissingProperty that is not annotated. This is the PR that fixes it: eclipse/microprofile-config#743

The problem 1 is that fix is not in any maven release, so we cannot use it yet.

The problem 2 is that fix contains other changes that makes other test to fail:

[ERROR] Tests run: 469, Failures: 1, Errors: 0, Skipped: 192, Time elapsed: 31.365 s <<< FAILURE! - in TestSuite
[ERROR] org.eclipse.microprofile.config.tck.ConverterTest.arquillianBeforeClass  Time elapsed: 0.07 s  <<< FAILURE!
org.jboss.arquillian.container.spi.client.container.DeploymentException: Deployment failure!
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.lambda$deploy$0(HelidonDeployableContainer.java:211)
	at java.base/java.util.Optional.map(Optional.java:260)
	at io.helidon.microprofile.arquillian.HelidonDeployableContainer.deploy(HelidonDeployableContainer.java:210)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:151)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$3.call(ContainerDeployController.java:118)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.executeOperation(ContainerDeployController.java:239)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deploy(ContainerDeployController.java:118)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createDeploymentContext(ContainerDeploymentContextHandler.java:71)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createContainerContext(ContainerDeploymentContextHandler.java:54)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.container.impl.client.container.DeploymentExceptionHandler.verifyExpectedExceptionDuringDeploy(DeploymentExceptionHandler.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:92)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController$1.perform(ContainerDeployController.java:77)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachDeployment(ContainerDeployController.java:232)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.forEachManagedDeployment(ContainerDeployController.java:212)
	at org.jboss.arquillian.container.impl.client.container.ContainerDeployController.deployManaged(ContainerDeployController.java:77)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.test.impl.client.ContainerEventController.execute(ContainerEventController.java:96)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.test.impl.TestContextHandler.createClassContext(TestContextHandler.java:83)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.test.impl.TestContextHandler.createSuiteContext(TestContextHandler.java:69)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.test.impl.EventTestRunnerAdaptor.beforeClass(EventTestRunnerAdaptor.java:89)
	at org.jboss.arquillian.testng.Arquillian.arquillianBeforeClass(Arquillian.java:99)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:65)
	at org.testng.internal.invokers.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:381)
	at org.testng.internal.invokers.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:319)
	at org.testng.internal.invokers.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:178)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:122)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:808)
	at org.testng.TestRunner.run(TestRunner.java:603)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:429)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:423)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:383)
	at org.testng.SuiteRunner.run(SuiteRunner.java:326)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1249)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
	at org.testng.TestNG.runSuites(TestNG.java:1092)
	at org.testng.TestNG.run(TestNG.java:1060)
	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:284)
	at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75)
	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:119)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: org.jboss.weld.exceptions.DeploymentException: WELD-001409: Ambiguous dependencies for type InjectingBean with qualifiers @Default
  at injection point [BackedAnnotatedField] @Inject org.eclipse.microprofile.config.tck.ConverterTest.bean
  at org.eclipse.microprofile.config.tck.ConverterTest.bean(ConverterTest.java:0)
  Possible dependencies: 
  - Managed Bean [class org.eclipse.microprofile.config.tck.ConverterTest$InjectingBean] with qualifiers [@Any @Default],
  - Managed Bean [class org.eclipse.microprofile.config.tck.ConverterTest$InjectingBean] with qualifiers [@Any @Default]

	at org.jboss.weld.bootstrap.Validator.validateInjectionPointForDeploymentProblems(Validator.java:375)
	at org.jboss.weld.bootstrap.Validator.validateInjectionPoint(Validator.java:285)
	at org.jboss.weld.bootstrap.Validator.validateGeneralBean(Validator.java:141)
	at org.jboss.weld.bootstrap.Validator.validateRIBean(Validator.java:162)
	at org.jboss.weld.bootstrap.Validator.validateBean(Validator.java:515)
	at org.jboss.weld.bootstrap.ConcurrentValidator$1.doWork(ConcurrentValidator.java:64)
	at org.jboss.weld.bootstrap.ConcurrentValidator$1.doWork(ConcurrentValidator.java:62)
	at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:62)
	at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:55)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedInterruptibleCallable.exec(ForkJoinTask.java:1489)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1311)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1840)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1806)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

I think it makes more sense that I run the tests against master of https://github.com/eclipse/microprofile-config and see what are the errors. In case there are errors, I will try to fix them, either in helidon or in microprofile-config. If the fixes applies in microprofile-config, we will wait for a new release.

jbescos · 2023-01-18T07:26:45Z

When running the TCKs to master microprofile-config, it fails because of this PR: eclipse/microprofile-config#701

Reverting that, it works. I am going to investigate that.

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos · 2023-01-18T09:43:42Z

I have created a PR in microprofile-confiig

Signed-off-by: Jorge Bescos Gascon <[email protected]>

tomas-langer

Please create follow up issues for the disabled tests.

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java

microprofile/weld/weld-core-impl/src/main/java/org/jboss/weld/bean/proxy/ProxyFactory.java

Signed-off-by: Jorge Bescos Gascon <[email protected]>

tomas-langer · 2023-01-31T14:49:49Z

@spericas could you please review the fault tolerance part? I have reviewed the rest and I am OK with it.
Thanks

4.x: Upgrade Weld to 5.x helidon-io#5815 Signed-off-by: Jorge Bescos Gascon <[email protected]>

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 11, 2023

jbescos force-pushed the issue5815 branch from de82f94 to 81e82f2 Compare January 11, 2023 12:11

jbescos marked this pull request as draft January 11, 2023 12:26

jbescos force-pushed the issue5815 branch 2 times, most recently from 8f0965a to b052486 Compare January 11, 2023 13:57

4.x: Upgrade Weld to 5.x helidon-io#5815

fe6e885

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch from b052486 to fe6e885 Compare January 11, 2023 14:32

Config TCK fixes

6669c70

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos mentioned this pull request Jan 18, 2023

Avoid throwing Exception for Optional types and ConfigValue if expression cannot be expanded eclipse/microprofile-config#767

Merged

jbescos added 3 commits January 23, 2023 10:29

Merge with master

7c4600c

Signed-off-by: Jorge Bescos Gascon <[email protected]>

Fix oci dependency

b5dacbc

Signed-off-by: Jorge Bescos Gascon <[email protected]>

Merge master

3baf13c

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch 3 times, most recently from 4104eab to 5ab2017 Compare January 23, 2023 15:50

jbescos mentioned this pull request Jan 24, 2023

Weld cannot find beans because of missing annotation eclipse/microprofile-fault-tolerance#614

Closed

jbescos force-pushed the issue5815 branch 4 times, most recently from 53a1643 to fa201af Compare January 24, 2023 11:51

jbescos marked this pull request as ready for review January 24, 2023 12:31

jbescos force-pushed the issue5815 branch from 02e4441 to fa201af Compare January 25, 2023 11:21

Exclude packages in config-tck

1e3e616

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch from fa201af to 1e3e616 Compare January 25, 2023 11:50

Merge branch 'main' into issue5815

b7c763c

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch 2 times, most recently from 8745d66 to 656cc47 Compare January 26, 2023 09:50

Fix fault tolerance

048e004

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch from 656cc47 to 048e004 Compare January 26, 2023 10:36

tomas-langer requested changes Jan 27, 2023

View reviewed changes

config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java Show resolved Hide resolved

microprofile/weld/weld-core-impl/src/main/java/org/jboss/weld/bean/proxy/ProxyFactory.java Outdated Show resolved Hide resolved

jbescos added 3 commits January 31, 2023 09:12

Merge branch 'main' into issue5815

da504c3

Signed-off-by: Jorge Bescos Gascon <[email protected]>

Upgrade Jersey 3.1.0

893eb75

Signed-off-by: Jorge Bescos Gascon <[email protected]>

Format ProxyFactory.java

ca37dff

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch 4 times, most recently from 792d396 to 37bde60 Compare January 31, 2023 14:47

Adding one test in config-mp

13eb274

Signed-off-by: Jorge Bescos Gascon <[email protected]>

jbescos force-pushed the issue5815 branch from 37bde60 to 13eb274 Compare January 31, 2023 14:48

tomas-langer requested a review from spericas January 31, 2023 14:49

tomas-langer approved these changes Jan 31, 2023

View reviewed changes

spericas approved these changes Feb 6, 2023

View reviewed changes

jbescos merged commit 34069f8 into helidon-io:main Feb 6, 2023

Captain1653 mentioned this pull request Feb 7, 2023

Use Hamcrest assertions instead of JUnit in examples/quickstarts/helidon-quickstart-mp - backport main (#1749) #6103

Merged

This was referenced Feb 7, 2023

Enable microprofile/tests/tck/tck-config/src/test/tck-suite.xml tests #6105

Open

LRA TCK failing randomly #6106

Closed

jbescos added a commit to jbescos/helidon that referenced this pull request May 5, 2023

4.x: Upgrade Weld to 5.x helidon-io#5815 (helidon-io#5830)

113c1fb

4.x: Upgrade Weld to 5.x helidon-io#5815 Signed-off-by: Jorge Bescos Gascon <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.x: Upgrade Weld to 5.x #5815 #5830

4.x: Upgrade Weld to 5.x #5815 #5830

jbescos commented Jan 11, 2023 •

edited

Loading

jbescos commented Jan 18, 2023

jbescos commented Jan 18, 2023

jbescos commented Jan 18, 2023

tomas-langer left a comment

tomas-langer commented Jan 31, 2023

4.x: Upgrade Weld to 5.x #5815 #5830

4.x: Upgrade Weld to 5.x #5815 #5830

Conversation

jbescos commented Jan 11, 2023 • edited Loading

jbescos commented Jan 18, 2023

jbescos commented Jan 18, 2023

jbescos commented Jan 18, 2023

tomas-langer left a comment

Choose a reason for hiding this comment

tomas-langer commented Jan 31, 2023

jbescos commented Jan 11, 2023 •

edited

Loading