Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OCI Java SDK shaded jar with v3 for OCI integration #5704

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Replace OCI Java SDK shaded jar with v3 for OCI integration #5704

merged 8 commits into from
Dec 16, 2022

Conversation

klustria
Copy link
Member

No description provided.

@klustria klustria added the 3.x Issues for 3.x version branch label Dec 15, 2022
@klustria klustria self-assigned this Dec 15, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 15, 2022
ljnelson
ljnelson previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only one minor comment

@klustria
Copy link
Member Author

Updated problem with oci atp example where pom.xml is referencing v2.5.5 rather than v3.0.3.

ljnelson
ljnelson previously approved these changes Dec 15, 2022
View reviewed changes
@klustria klustria requested a review from ljnelson December 16, 2022 03:29
@klustria
Copy link
Member Author

Tested Monitoring and Logging. Also tested Object Storage Example.

ljnelson
ljnelson previously approved these changes Dec 16, 2022
View reviewed changes
@klustria
Copy link
Member Author

Tested OCI vault example and works well.

@klustria
Copy link
Member Author

Tested metrics reactive which is SE based and found that it needs to have this included as a dependency for the app to work:

<dependency>
    <groupId>com.oracle.oci.sdk</groupId>
    <artifactId>oci-java-sdk-common-httpclient-jersey3</artifactId>
</dependency>

@klustria
Copy link
Member Author

The examples for vault-reactive and objectstorage-reactive also requires jersey3 httpclient dependency to be added.

arjav-desai
arjav-desai previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klustria klustria dismissed stale reviews from arjav-desai and ljnelson via b3c412f December 16, 2022 18:59
@klustria klustria mentioned this pull request Dec 16, 2022
Closed
@klustria klustria merged commit 2a4044f into helidon-io:helidon-3.x Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@ljnelson ljnelson ljnelson left review comments

@arjav-desai arjav-desai Awaiting requested review from arjav-desai

Assignees

@klustria klustria

Labels
3.x Issues for 3.x version branch OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klustria @ljnelson @barchetta @arjav-desai