Declare h1-prefix as early as possible so it is used for the title prefix
#5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
barchetta
approved these changes
Dec 13, 2022
| @@ -17,6 +17,7 @@ | |||
| /////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| = Metrics-Capable Modules | |||
| :h1-prefix: MP | |||
| :description: Helidon MP metrics-capable modules | |||
| :keywords: helidon, metrics, metrics-capable, microprofile, guide | |||
| :intro-project-name: {h1-prefix} | |||
There was a problem hiding this comment.
How about moving :intro-project-name: {h1-prefix} after the include of mp.adoc ; does that work ?
There was a problem hiding this comment.
Another way, which I think is better, is to use conditionals in the common content directly.
This makes the common docs "polymorphic" (big word :D) ; and sort of standalone (as it depends on the flavor include).
It does simplify the "contract" of these kind of common documents.
It can also help the GitHub rendering and set default values for the cases where the required attributes are not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5665
Even though
includes/mp.adocdeclaresh1-prefixasMP, andmp/metrics/metrics-capable-components.adocincludesmp.adoc[], the only way I found to get the prefix on the rendered page to work was to declareh1-prefixreally early in themp/metrics/metrics-capable-components.adocfile.