Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tyrus integration into Nima #5464

Merged
merged 13 commits into from
Nov 28, 2022
Merged

Tyrus integration into Nima #5464

merged 13 commits into from
Nov 28, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Nov 17, 2022

New implementation of microprofile.tyrus module that integrate Tyrus with Nima:

  • New upgrade provider with higher priority for Tyrus that forwards handshake
  • New connection logic to pass data in and out of Tyrus
  • Support for declarative and programmatic WS endpoints
  • New tests based on @HelidonTest for echoing messages using JDK WS client
  • Modified CDI extension to discover WS artifacts

@spericas spericas added websocket WebSocket in Helidon 4.x Version 4.x labels Nov 17, 2022
@spericas spericas added this to the 4.0.0 milestone Nov 17, 2022
@spericas spericas self-assigned this Nov 17, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 17, 2022
@spericas spericas marked this pull request as draft November 17, 2022 15:22
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas spericas marked this pull request as ready for review November 22, 2022 13:49
@spericas spericas changed the title Tyrus integration into Nima (draft) Tyrus integration into Nima Nov 22, 2022
trentjeff pushed a commit to trentjeff/helidon that referenced this pull request Nov 29, 2022
* Restored Tyrus module in Nima MP.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Updated dependencies and socket routing code.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Initial integration of Tyrus with Nima. Simple echo test works using the JDK's WS client.

* Fixed checkstyle issues.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Simplified TyrusConnection by not extending WsConnection. Restored some changes in Nima's WS module.

* Some general code cleanup.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Renamed some classes for consistency. Refactored tests for declarative and programmatic styles and to use @HelidonTest.

* Support for @RoutingPath annotation.

* Fixed checkstyle errors.

* New test for extensions that uses the Tyrus client after fixes in Nima.

* New test that combines REST and WS endpoint on same port.

* Restored examples that use websockets.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

* Order of protected fields and use putIfAbsent.

Signed-off-by: Santiago Pericasgeertsen <[email protected]>

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. websocket WebSocket in Helidon
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants