-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tyrus integration into Nima #5464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Nov 17, 2022
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
…the JDK's WS client.
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
…me changes in Nima's WS module.
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
…e and programmatic styles and to use @HelidonTest.
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
tomas-langer
requested changes
Nov 21, 2022
...bserver/webserver/src/main/java/io/helidon/nima/webserver/http1/Http1ConnectionProvider.java
Outdated
Show resolved
Hide resolved
...websocket/webserver/src/main/java/io/helidon/nima/websocket/webserver/WsUpgradeProvider.java
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas
changed the title
Tyrus integration into Nima (draft)
Tyrus integration into Nima
Nov 22, 2022
tomas-langer
approved these changes
Nov 23, 2022
This was referenced Nov 28, 2022
trentjeff
pushed a commit
to trentjeff/helidon
that referenced
this pull request
Nov 29, 2022
* Restored Tyrus module in Nima MP. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Updated dependencies and socket routing code. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Initial integration of Tyrus with Nima. Simple echo test works using the JDK's WS client. * Fixed checkstyle issues. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Simplified TyrusConnection by not extending WsConnection. Restored some changes in Nima's WS module. * Some general code cleanup. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Renamed some classes for consistency. Refactored tests for declarative and programmatic styles and to use @HelidonTest. * Support for @RoutingPath annotation. * Fixed checkstyle errors. * New test for extensions that uses the Tyrus client after fixes in Nima. * New test that combines REST and WS endpoint on same port. * Restored examples that use websockets. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Order of protected fields and use putIfAbsent. Signed-off-by: Santiago Pericasgeertsen <[email protected]> Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
websocket
WebSocket in Helidon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation of
microprofile.tyrus
module that integrate Tyrus with Nima:@HelidonTest
for echoing messages using JDK WS client