Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4269 openapi tools examples #5250

Merged
merged 16 commits into from
Dec 13, 2022

Conversation

aserkes
Copy link
Contributor

@aserkes aserkes commented Oct 25, 2022

Helidon examples for OpenApi Tools

resolves #4269

Signed-off-by: aserkes <[email protected]>
Signed-off-by: aserkes <[email protected]>
@aserkes aserkes self-assigned this Oct 25, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 25, 2022
@aserkes aserkes requested review from ljamen and tjquinno October 25, 2022 14:46
@aserkes aserkes changed the title 4269 openapi tools examples [WIP] 4269 openapi tools examples Oct 25, 2022
# Conflicts:
#	etc/checkstyle-suppressions.xml
Signed-off-by: aserkes <[email protected]>
@aserkes aserkes changed the title [WIP] 4269 openapi tools examples 4269 openapi tools examples Oct 26, 2022
@barchetta barchetta added the 4.x Version 4.x label Nov 17, 2022
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested quite a few changes in the README.md files. Please make the same changes in the corresponding source files.

examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-se/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
@aserkes aserkes requested a review from tjquinno December 8, 2022 18:43
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more changes.

examples/openapi-tools/quickstart-se/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-se/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-se/README.md Outdated Show resolved Hide resolved
@aserkes aserkes requested a review from tjquinno December 13, 2022 08:15
@aserkes aserkes merged commit 135bf6b into helidon-io:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants