Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAXRS doc updates for 3611 #5225

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

ljamen
Copy link
Contributor

@ljamen ljamen commented Oct 20, 2022

fixes #3611
#3611

@ljamen ljamen added the docs label Oct 20, 2022
@ljamen ljamen requested a review from tjquinno October 20, 2022 16:12
@ljamen ljamen self-assigned this Oct 20, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 20, 2022
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It's possible that Helidon invokes the Application getClasses method (exposed like getSingletons) multiple times, although I'm not sure about that. Probably developers should not assume single invocations of either method. Not sure this warrants further changes so I'm approving this. Maybe Santiago would know for sure?

@ljamen ljamen merged commit 430ab8b into helidon-io:helidon-3.x Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation that Helidon can invoke JAX-RS Application.getSingletons multiple times
2 participants