Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Helidon Pico #5141

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Introduce Helidon Pico #5141

merged 11 commits into from
Oct 12, 2022

Conversation

trentjeff
Copy link
Member

This PR introduces Pico, specifically the API and Types modules.

@trentjeff trentjeff self-assigned this Oct 10, 2022
@trentjeff trentjeff added 4.x Version 4.x declarative Helidon Declarative labels Oct 10, 2022
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not to contain any code. This should not work with our pipelines (Javadoc should fail on this). Also hard to approve module names when we do not know what is the content.

.gitignore Outdated Show resolved Hide resolved
pico/.gitignore Outdated Show resolved Hide resolved
pico/api/src/main/java/module-info.java Show resolved Hide resolved
pico/pom.xml Outdated Show resolved Hide resolved
pico/pom.xml Outdated Show resolved Hide resolved
pico/types/pom.xml Outdated Show resolved Hide resolved
pico/pom.xml Show resolved Hide resolved
pico/types/pom.xml Outdated Show resolved Hide resolved
@trentjeff trentjeff marked this pull request as ready for review October 11, 2022 20:57
tomas-langer
tomas-langer previously approved these changes Oct 12, 2022
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trentjeff trentjeff merged commit a4ea634 into helidon-io:main Oct 12, 2022
@trentjeff trentjeff mentioned this pull request Nov 4, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x declarative Helidon Declarative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants