Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add some retries because post-request metrics updates occur after the response is sent #5136

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

tjquinno
Copy link
Member

Resolves #5029

See explanation in #5122

Signed-off-by: [email protected] [email protected]

@tjquinno tjquinno self-assigned this Oct 10, 2022
@tjquinno tjquinno changed the title Add some retries because post-request metrics update occur after the response is sent [3.x] Add some retries because post-request metrics update occur after the response is sent Oct 10, 2022
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno changed the title [3.x] Add some retries because post-request metrics update occur after the response is sent [3.x] Add some retries because post-request metrics updates occur after the response is sent Oct 10, 2022
@tjquinno tjquinno merged commit 42b3247 into helidon-io:helidon-3.x Oct 10, 2022
@tjquinno tjquinno deleted the asyncresponsetest-fix-3.x branch October 10, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] Intermittent HelloWorldAsyncResponseTest.testAsyncWithArg
2 participants