Remove retries from executor metrics test fix; use the pre-existing countdown latch in GreetService instead
#5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4982
Daniel's recent PR improved on my original one that used retries, but retrying is not the correct approach here.
In fact, we cannot depend on the reported values changing as we would like.
The executor service metrics we implement rely on
ThreadPoolExecutormethods which are documented as returning estimates of task counts, etc. Even if retry seems to help, there is no guarantee that the numbers reported byThreadPoolExecutor- and therefore the values reported by our metrics - will change as a result of running one async task in the executor.We can still check to make sure that the expected metrics are created; we just cannot reliably test that the values increase.