fix for issue in handling ConfigProperties using List #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested changes
Sep 26, 2022
microprofile/config/src/main/java/io/helidon/microprofile/config/FieldSetter.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Sep 27, 2022
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/test/java/io/helidon/microprofile/config/ConfigBeanDescriptorTest.java
Outdated
Show resolved
Hide resolved
tomas-langer
previously approved these changes
Oct 3, 2022
trentjeff
force-pushed
the
issue-4691-convert-string-to-list
branch
from
a54bbf1 to
2448e11
Compare
…rt for List conversion of MP config.
trentjeff
force-pushed
the
issue-4691-convert-string-to-list
branch
from
2448e11 to
d5a3b25
Compare
romain-grecourt
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #4691 .