Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown executors while stopping the server #4819

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

spericas
Copy link
Member

Attempt to shutdown executors gracefully while the server is being stopped. After shutdown, no new ConnectionHandler will be accepted for execution (submit() call on executor will fail).

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas spericas self-assigned this Aug 31, 2022
@spericas spericas changed the title WIP: Shutdown executors while stopping the server Shutdown executors while stopping the server Sep 8, 2022
@spericas spericas removed the wip label Sep 8, 2022
@spericas spericas added this to the 4.0.0 milestone Sep 8, 2022
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 8233e66 into helidon-io:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Níma Helidon Níma webserver
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants