Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Docs PR] Config Docs #4477

Merged
merged 10 commits into from
Jul 18, 2022
Merged

[New Docs PR] Config Docs #4477

merged 10 commits into from
Jul 18, 2022

Conversation

arjav-desai
Copy link
Member

@arjav-desai arjav-desai commented Jul 7, 2022 •
edited
Loading

Addresses #4304 and #4321

Ports #4253 and #4251 to Master as well

@arjav-desai arjav-desai added this to the 3.0.0 milestone Jul 7, 2022
@arjav-desai arjav-desai self-assigned this Jul 7, 2022
@arjav-desai arjav-desai marked this pull request as ready for review July 8, 2022 14:04
klustria
klustria previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant to changes for #4251 and #4253, I'm approving this

@arjav-desai arjav-desai requested a review from klustria July 9, 2022 14:45
ljamen
ljamen reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Small updates and some questions for Mitia re: headings.

docs/mp/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/mp/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/mp/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
docs/mp/config/introduction.adoc Outdated Show resolved Hide resolved
docs/mp/config/introduction.adoc Show resolved Hide resolved
docs/se/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
tomas-langer
tomas-langer previously requested changes Jul 13, 2022
View reviewed changes
docs/mp/config/introduction.adoc Outdated Show resolved Hide resolved
docs/se/config/advanced-configuration.adoc Outdated Show resolved Hide resolved
@arjav-desai arjav-desai marked this pull request as draft July 14, 2022 15:36
@arjav-desai arjav-desai marked this pull request as ready for review July 18, 2022 15:39
@arjav-desai arjav-desai dismissed tomas-langer’s stale review July 18, 2022 15:40

Changes are incorporated but dismissing for merge

klustria
klustria approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just one nitpick... change ToC to Contents, but that can also be done in the next iteration.

@arjav-desai arjav-desai merged commit 0695295 into helidon-io:master Jul 18, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
@arjav-desai @romain-grecourt
[New Docs PR] Config Docs (helidon-io#4477)
a44320d
@arjav-desai arjav-desai deleted the helidon-4304 branch August 22, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klustria klustria klustria approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

@ljamen ljamen Awaiting requested review from ljamen

Assignees

@arjav-desai arjav-desai

Labels
docs
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arjav-desai @tomas-langer @ljamen @klustria