Propagate any existing server context into a Webclient reactive code (helidon-2.x) #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread. Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas
changed the title
…a Single with a SingleWithContext to ensure any actions or functions called have context available. Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas
changed the title
spericas
changed the title
danielkec
reviewed
Dec 20, 2021
webclient/webclient/src/main/java/io/helidon/webclient/SingleWithContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
spericas
force-pushed
the
issue-3734-2.x
branch
from
3a8d8d7 to
c115ae0
Compare
spericas
changed the title
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
danielkec
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about Helidon's context propagation to non-request threads (typically Netty threads). It makes the current context available to any reactive code handler in WebClient and also ensures context is propagated if
req.next()is called inside Helidon in a different thread. Customer has verified that this PR fixes their application. See Issue #3734 for a discussion.