Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging - swallowed exception from CS #3892

Closed
danielkec opened this issue Feb 14, 2022 · 1 comment · Fixed by #3911 or #3957
Closed

Messaging - swallowed exception from CS #3892

danielkec opened this issue Feb 14, 2022 · 1 comment · Fixed by #3911 or #3957
Assignees
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working messaging Reactive Messaging P2

Comments

@danielkec
Copy link
Contributor

Thanks @santhoshpt for finding the bug, signature INCOMING_COMPLETION_STAGE_2_MSG swallows CS exception.

	@Incoming("fromKafka")
	public void getMessages(Message<String> message) {
		return CompletableFuture.failedFuture(new RuntimeException());
	}
@danielkec danielkec added bug Something isn't working 2.x Issues for 2.x version branch messaging Reactive Messaging 3.x Issues for 3.x version branch labels Feb 14, 2022
@danielkec danielkec self-assigned this Feb 14, 2022
@danielkec
Copy link
Contributor Author

Workaround:

    @Incoming("fromKafka")
    @Acknowledgment(Acknowledgment.Strategy.MANUAL)
    public SubscriberBuilder<Message<String>, Void> getMessages() {
        return ReactiveStreams.<Message<String>>builder()
                .map(msg -> {
                     return CompletableFuture.failedFuture(new RuntimeException());
                })
                .flatMap(ReactiveStreams::fromCompletionStageNullable)
                .onError(t -> LOG.log(Level.SEVERE, "Stream killed by error", t))
                .ignore();
    }

@m0mus m0mus added the P2 label Feb 14, 2022
danielkec added a commit to danielkec/helidon that referenced this issue Feb 22, 2022
danielkec added a commit that referenced this issue Mar 4, 2022
)

* Fix badly subscribed connector to processor signature #3904

Signed-off-by: Daniel Kec <[email protected]>

* Fix swallowed exception from CS #3892

Signed-off-by: Daniel Kec <[email protected]>
danielkec added a commit to danielkec/helidon that referenced this issue Mar 10, 2022
…lidon-io#3911)

* Fix badly subscribed connector to processor signature helidon-io#3904
* Fix swallowed exception from CS helidon-io#3892

Signed-off-by: Daniel Kec <[email protected]>
danielkec added a commit that referenced this issue Mar 18, 2022
) (#3957)

* Fix badly subscribed connector to processor signature #3904
* Fix swallowed exception from CS #3892

Signed-off-by: Daniel Kec <[email protected]>
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working messaging Reactive Messaging P2
Projects
Archived in project
2 participants