3.x Make OciMetricsDataTest.beforeEach public (#7328)

helidon-io · Jan 2, 2024 · aad1d2c · aad1d2c
1 parent d3f7edf
commit aad1d2c
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/...metrics/metrics/src/test/java/io/helidon/integrations/oci/metrics/OciMetricsDataTest.java b/...metrics/metrics/src/test/java/io/helidon/integrations/oci/metrics/OciMetricsDataTest.java
@@ -28,15 +28,14 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.TimeUnit;
 
 import io.helidon.metrics.api.RegistryFactory;
 
 import org.eclipse.microprofile.metrics.MetricRegistry.Type;
 
 import com.oracle.bmc.monitoring.model.MetricDataDetails;
 
-public class OciMetricsDataTest {
+class OciMetricsDataTest {
     private final OciMetricsSupport.NameFormatter nameFormatter = new OciMetricsSupport.NameFormatter() { };
     private final Type[] types = {Type.BASE, Type.VENDOR, Type.APPLICATION};
     private final String dimensionScopeName = "scope";
@@ -47,21 +46,15 @@ public class OciMetricsDataTest {
     private final MetricRegistry appMetricRegistry = rf.getRegistry(Type.APPLICATION);
 
     @BeforeEach
-    private void beforeEach() {
-        // clear all registry
+    void clearAllRegistry() {
         for (Type type: types) {
             MetricRegistry metricRegistry = rf.getRegistry(type);
-            metricRegistry.removeMatching(new MetricFilter() {
-                @Override
-                public boolean matches(MetricID metricID, Metric metric) {
-                    return true;
-                }
-            });
+            metricRegistry.removeMatching(MetricFilter.ALL);
         }
     }
 
     @Test
-    public void testMetricRegistries() {
+    void testMetricRegistries() {
         String counterName = "DummyCounter";
         String meterName = "DummyMeter";
         String timerName = "DummyTimer";
@@ -96,7 +89,7 @@ public void testMetricRegistries() {
     }
 
     @Test
-    public void testOciMonitoringParameters() {
+    void testOciMonitoringParameters() {
         String compartmentId = "dummy.compartmentId";
         String namespace = "dummy-namespace";
         String resourceGroup = "dummy_resourceGroup";
@@ -114,7 +107,7 @@ public void testOciMonitoringParameters() {
     }
 
     @Test
-    public void testDimensions() {
+    void testDimensions() {
         String dummyTagName = "DummyTag";
         String dummyTagValue = "DummyValue";