Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boot_time returns current time on windows #345

Open
Orycterope opened this issue Sep 27, 2021 · 0 comments · May be fixed by #346
Open

boot_time returns current time on windows #345

Orycterope opened this issue Sep 27, 2021 · 0 comments · May be fixed by #346

Comments

@Orycterope
Copy link

The windows implementation of boot_time is wrong: it gets the current time, converts windows epoch to unix epoch, but never actually subtracts the boot time of the machine.

Here's a valid implementation in psutil for example: it gets the current time, subtracts the number of milliseconds since boot, and converts this instant to unix epoch.
Orycterope added a commit to Orycterope/heim that referenced this issue Sep 27, 2021
@Orycterope
Fix boot_time on windows
0d28d37 
Fixes heim-rs#345
@Orycterope Orycterope linked a pull request Sep 27, 2021 that will close this issue
Open
Orycterope added a commit to Orycterope/heim that referenced this issue Sep 28, 2021
@Orycterope
Fix boot_time on windows
80c327e 
Fixes heim-rs#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix boot_time on windows Orycterope/heim
1 participant
@Orycterope