Remove ldap errors in behat tests #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the ldap-errors that occured due to already existing entries from previous calls. For that we first check whether the entry already exists and if so, delete it so that it can then be recreated. I opted for this approach instewad of keeping the old entries as the new one might have slightly different information that would then break the tests.
This makes sure that WordPress is only installed once at the beginning and also makes sure that the admin-email page is not displayed every now and then. That requires some magic but as that only happes once at the beginning that is OK.
heiglandreas
force-pushed
the
update-behat
branch
from
cad1042 to
0f0d7dd
Compare
heiglandreas
force-pushed
the
update-behat
branch
from
d60cc40 to
0e51260
Compare
As that is specific to the respective WP-version
This allows to set up filters before running tests. This is especially relevant as a filter needs to be created to be able to assign multiple roles from LDAP at once.
This allows to use all wordpress versions on all PHP-versions and not depend on what WordPress has prebuilt
As we are now using our own matrix we can skip the exceptions as those were required to kinda work around the odd errors from the WordPress docker images
This reverts commit 381fca2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the ldap-errors that occured due to already existing
entries from previous calls. For that we first check whether the entry
already exists and if so, delete it so that it can then be recreated.
I opted for this approach instewad of keeping the old entries as the new
one might have slightly different information that would then break the
tests.
Fixes #254