Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove higher kind from Gen/Property/Tree #70

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Conversation

charleso
Copy link
Collaborator

@jystic @moodmosaic

Two main reasons for removing this.

  1. It's unlikely that it's actually going to be used by 99.99% of
    users. That is if we had any...

  2. To the previous point, removing the kind will hopefully
    increase the chances of not scaring off potential users.

Two main reasons for removing this.

1. It's unlikely that it's actually going to be used by 99.99% of
   users. That is if we had any...

2. To the previous point, removing the kind will hopefully
   increase the chances of not scaring off potential users.
@charleso charleso merged commit a1aa34f into master Apr 21, 2019
@charleso charleso deleted the topic/rm-higher-kind branch April 21, 2019 22:25
@jacobstanley
Copy link
Member

I would like to remove it from Gen/Tree in the Haskell version but I don't think it's possible while retaining the nice monadic forAll syntax. We don't have a higher kind in the F# version because we can have side effects.

@charleso
Copy link
Collaborator Author

We don't have a higher kind in the F# version because we can have side effects.

Same with Scala. I didn't mind adding adding it to begin with, but doesn't seem like it's buying me much at this stage. I'm definitely happy to re-add if/when there's enough demand.

@moodmosaic
Copy link
Member

Sorry, just catching up, back from holidays.

@moodmosaic
Copy link
Member

We don't have a higher kind in the F# version because we can have side effects.

Same with Scala. I didn't mind adding adding it to begin with, but doesn't seem like it's buying me much at this stage. I'm definitely happy to re-add if/when there's enough demand.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants