Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant Show constraints: evalMaybe, evalMaybeM #516

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove redundant Show constraints: evalMaybe, evalMaybeM #516

merged 2 commits into from
Apr 8, 2024

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Apr 8, 2024

No description provided.

moodmosaic
moodmosaic approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Since evalMaybe doesn't utilize show on type a, and there's no need for a in logging or error messages, removing the Show a constraint is justified.

CHANGELOG.md Outdated Show resolved Hide resolved
@moodmosaic moodmosaic merged commit 591af23 into hedgehogqa:master Apr 8, 2024
9 checks passed
@endgame endgame deleted the redundant-show-constraints branch July 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristano8 Tristano8 Tristano8 approved these changes

@moodmosaic moodmosaic moodmosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endgame @moodmosaic @Tristano8