-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHC 9.4 compatibility #461
Conversation
Thank you, @ysangkok 👍 Shouldn't we also add an entry in the CI build for 9.4.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ysangkok 👍 Shouldn't we also add an entry in the CI build for 9.4.1?
Hmm... It looks like CI failed to fetch Cabal 3.8 (required by GHC 9.4). That could be an issue with GHCUp or with the (no longer maintained) actions/setup-haskell. |
@ysangkok let's see if the changes you force-pushed will go through (I've noticed you removed Cabal 3.8, but IIRC that's the minimum required version that'll work with GHC 9.4). 👀 |
@moodmosaic I replaced Cabal 3.4 with Cabal 3.8. The failure was because GHCup apparently requires the full version number, I don't think it was related to setup-haskell. The build passes now, I think this is good to go. |
cabal: ["3.4"] | ||
ghc: ["8.0.2", "8.2.2", "8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.2.1"] | ||
cabal: ["3.8.1.0"] | ||
ghc: ["8.0.2", "8.2.2", "8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.2.4", "9.4.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦔🐾👍
Yep! 👍 That's fine. |
Available in hedgehog 1.2. |
* GHC 9.4 compatibility * CI: Add GHC 9.4.1, use Cabal 3.8
This allows compatibility with GHC 9.4. Tested with
cabal test -w ghc-9.4.1
.The extension is added because of this new warning: