Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.4 compatibility #461

Merged
merged 2 commits into from
Aug 15, 2022
Merged

GHC 9.4 compatibility #461

merged 2 commits into from
Aug 15, 2022

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Aug 14, 2022

This allows compatibility with GHC 9.4. Tested with cabal test -w ghc-9.4.1.

The extension is added because of this new warning:

src/Hedgehog/Internal/Gen.hs:312:46: error: [-Wtype-equality-requires-operators, -Werror=type-equality-requires-operators]
    The use of ‘~’ without TypeOperators
    will become an error in a future GHC release.
    Suggested fix: Perhaps you intended to use TypeOperators
    |
312 | toTree :: forall m a. (MonadGen m, GenBase m ~ Identity) => m a -> m (Tree a)

@ysangkok ysangkok changed the title Bump template-haskell to allow 2.19 (GHC 9.4) GHC 9.4 compatibility Aug 14, 2022
@moodmosaic
Copy link
Member

Thank you, @ysangkok 👍 Shouldn't we also add an entry in the CI build for 9.4.1?

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ysangkok 👍 Shouldn't we also add an entry in the CI build for 9.4.1?

@moodmosaic
Copy link
Member

Hmm... It looks like CI failed to fetch Cabal 3.8 (required by GHC 9.4). That could be an issue with GHCUp or with the (no longer maintained) actions/setup-haskell.

@moodmosaic
Copy link
Member

moodmosaic commented Aug 15, 2022

@ysangkok let's see if the changes you force-pushed will go through (I've noticed you removed Cabal 3.8, but IIRC that's the minimum required version that'll work with GHC 9.4). 👀

@ysangkok
Copy link
Contributor Author

@moodmosaic I replaced Cabal 3.4 with Cabal 3.8. The failure was because GHCup apparently requires the full version number, I don't think it was related to setup-haskell. The build passes now, I think this is good to go.

cabal: ["3.4"]
ghc: ["8.0.2", "8.2.2", "8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.2.1"]
cabal: ["3.8.1.0"]
ghc: ["8.0.2", "8.2.2", "8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.2.4", "9.4.1"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👌

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦔🐾👍

@moodmosaic moodmosaic merged commit 4a4d563 into hedgehogqa:master Aug 15, 2022
@moodmosaic
Copy link
Member

@moodmosaic I replaced Cabal 3.4 with Cabal 3.8.

Yep! 👍 That's fine.

@moodmosaic
Copy link
Member

Available in hedgehog 1.2.

mbg pushed a commit to mbg/haskell-hedgehog that referenced this pull request Sep 2, 2022
* GHC 9.4 compatibility

* CI: Add GHC 9.4.1, use Cabal 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants