Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bytestring-0.11 #408

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Allow bytestring-0.11 #408

merged 1 commit into from
Dec 6, 2020

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Dec 2, 2020

Tested with the following config:

packages:
  hedgehog
  hedgehog-corpus
  hedgehog-dieharder
  hedgehog-example
  hedgehog-quickcheck
  hedgehog-test-laws

-- would like to do this but cabal applies it to
-- _all_ packages not just local :wtf:
--    https://github.com/haskell/cabal/issues/3883
-- program-options
--   ghc-options: -Wall -Werror

package hedgehog
  ghc-options: -Wall -Werror
package hedgehog-corpus
  ghc-options: -Wall -Werror
package hedgehog-dieharder
  ghc-options: -Wall -Werror
package hedgehog-example
  ghc-options: -Wall -Werror
package hedgehog-quickcheck
  ghc-options: -Wall -Werror
package hedgehog-test-laws
  ghc-options: -Wall -Werror

tests: True

constraints:
  bytestring >= 0.11

allow-newer:
  -- https://github.com/tibbe/hashable/pull/191
  hashable:bytestring,
  -- https://github.com/haskell/parsec/pull/116
  parsec:bytestring

source-repository-package
  type: git
  location: https://github.com/haskell/text
  tag: v1.2.4.1-rc1

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, @Bodigrim. Is this a blocker for stackage as in #396 (comment)? IIRC, there are a few breaking changes planned for bytestring-0.11.

@Bodigrim
Copy link
Contributor Author

Bodigrim commented Dec 5, 2020

As a maintainer of bytestring, I am reasonably confident that breaking changes in its last release do not affect hedgehog. They are pretty much limited to internal modules and GHC < 8.0. You can validate this claim using cabal config above; bytestring-0.11 has been released back in September.

(This is not a blocker for Stackage, yet)

@moodmosaic
Copy link
Member

Yep, you are right. I just checked the changelog. Thank you!

@moodmosaic moodmosaic merged commit b6c57fe into hedgehogqa:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants