Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only recheck shrunken input #336

Merged
merged 6 commits into from
Dec 12, 2021

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Sep 6, 2021

Resolves #332

...at least that is my plan. It is not there yet. So far, this branch adds Lazy<> to the definition of Property<>. I think that is the right first step to being able to avoid executing the test on non-shrunken inputs.

@dharmaturtle, can you help me with this? I got the Hedgehog project to compile. Can you make all projects compile?

@dharmaturtle

This comment has been minimized.

@TysonMN

This comment has been minimized.

@TysonMN

This comment has been minimized.

@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch 2 times, most recently from 661c169 to c969c98 Compare September 9, 2021 03:51
@TysonMN

This comment has been minimized.

@dharmaturtle

This comment has been minimized.

@ghost

This comment has been minimized.

@TysonMN

This comment has been minimized.

@TysonMN

This comment has been minimized.

@TysonMN

This comment has been minimized.

@ThisFunctionalTom

This comment has been minimized.

@ghost

This comment has been minimized.

@TysonMN
Copy link
Member Author

TysonMN commented Sep 12, 2021

Yep @adam-becker. I did that so that I could submit issue Zaid-Ajaj/Fable.Mocha#38.

@ThisFunctionalTom, I think that is why the Fable test is failing. My assertion depends on the contents of the error message but Mocha isn't including the same information as Expecto in the error message.

@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch from 5597f92 to a266065 Compare September 12, 2021 03:29
@TysonMN
Copy link
Member Author

TysonMN commented Sep 12, 2021

@adam-becker, I just force pushed the dropping of that temp commit. All the .NET tests now pass. One JS test fails because my assertion is "too strong" (not because their is a problem in the production code).

The easies workaround is to drop that second assertion. If I took that approach, then I would only drop it for Fable. This issue with Mocha isn't preventing me from making progress on this feature at the moment (other than the small amount of time today to investigate the problem), so I will ignore it for a while as I continue working on this feature.

@ThisFunctionalTom

This comment has been minimized.

@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch 3 times, most recently from f2b0b5e to a2ad201 Compare September 15, 2021 01:36
@ghost ghost modified the milestones: 0.11.0, 0.12.0 Sep 21, 2021
@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch 2 times, most recently from f025a59 to 9fe84de Compare November 29, 2021 04:53
@TysonMN TysonMN marked this pull request as ready for review November 29, 2021 04:55
@TysonMN TysonMN changed the title [DRAFT] Recheck one input Only recheck shrunken input Nov 29, 2021
@TysonMN
Copy link
Member Author

TysonMN commented Nov 29, 2021

This PR is now ready for review. It needs some clean up at least in Property.reportRecheckWith. Also need to add a change log entry.

@TysonMN TysonMN requested a review from dharmaturtle November 29, 2021 04:59
CHANGELOG.md Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/PropertyTests.fs Outdated Show resolved Hide resolved
src/Hedgehog/Lazy.fs Outdated Show resolved Hide resolved
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
src/Hedgehog/Report.fs Outdated Show resolved Hide resolved
src/Hedgehog/Property.fs Show resolved Hide resolved
@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch from c7bfc93 to 3ea9bb5 Compare December 7, 2021 03:01
@TysonMN
Copy link
Member Author

TysonMN commented Dec 7, 2021

Force pushed after rebasing on master, to which was just added the code in PR #386. The code is much cleaner. Still more cleaning to do though.

@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch 2 times, most recently from 812b186 to 896c439 Compare December 8, 2021 01:43
@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch 2 times, most recently from 34c6b49 to cc125c0 Compare December 8, 2021 01:55
@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch from 0c02671 to 3e1de60 Compare December 8, 2021 02:32
@TysonMN
Copy link
Member Author

TysonMN commented Dec 8, 2021

I am happy with everything now. I squashed the commits I recently pushed into their respective places. Then I reviewed all changes via GitHub and ran tests locally on every commit.

Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/Hedgehog/Report.fs Outdated Show resolved Hide resolved
@TysonMN TysonMN force-pushed the feature/332_recheck_one_input branch from 3e1de60 to b39906d Compare December 12, 2021 19:08
@TysonMN TysonMN merged commit 2293751 into hedgehogqa:master Dec 12, 2021
@TysonMN TysonMN deleted the feature/332_recheck_one_input branch December 12, 2021 19:12
@TysonMN TysonMN mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to start a recheck from a fully shrunk case?
4 participants