Revert "Introduce SECP256K1_LOCAL_VAR macro"

This reverts commit c0f5b42.
hebasto · Nov 2, 2024 · bcc74d5 · bcc74d5
1 parent 0c9a046
commit bcc74d5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 20 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -47,7 +47,6 @@ noinst_HEADERS += src/assumptions.h
 noinst_HEADERS += src/checkmem.h
 noinst_HEADERS += src/testutil.h
 noinst_HEADERS += src/util.h
-noinst_HEADERS += src/util_local_visibility.h
 noinst_HEADERS += src/int128.h
 noinst_HEADERS += src/int128_impl.h
 noinst_HEADERS += src/int128_native.h

diff --git a/src/precomputed_ecmult.h b/src/precomputed_ecmult.h
@@ -13,8 +13,6 @@ extern "C" {
 
 #include "ecmult.h"
 #include "group.h"
-#include "util_local_visibility.h"
-
 #if defined(EXHAUSTIVE_TEST_ORDER)
 #    if EXHAUSTIVE_TEST_ORDER == 7
 #        define WINDOW_G 3
@@ -29,8 +27,8 @@ static secp256k1_ge_storage secp256k1_pre_g[ECMULT_TABLE_SIZE(WINDOW_G)];
 static secp256k1_ge_storage secp256k1_pre_g_128[ECMULT_TABLE_SIZE(WINDOW_G)];
 #else /* !defined(EXHAUSTIVE_TEST_ORDER) */
 #    define WINDOW_G ECMULT_WINDOW_SIZE
-SECP256K1_LOCAL_VAR const secp256k1_ge_storage secp256k1_pre_g[ECMULT_TABLE_SIZE(WINDOW_G)];
-SECP256K1_LOCAL_VAR const secp256k1_ge_storage secp256k1_pre_g_128[ECMULT_TABLE_SIZE(WINDOW_G)];
+extern const secp256k1_ge_storage secp256k1_pre_g[ECMULT_TABLE_SIZE(WINDOW_G)];
+extern const secp256k1_ge_storage secp256k1_pre_g_128[ECMULT_TABLE_SIZE(WINDOW_G)];
 #endif /* defined(EXHAUSTIVE_TEST_ORDER) */
 
 #ifdef __cplusplus

diff --git a/src/precomputed_ecmult_gen.h b/src/precomputed_ecmult_gen.h
@@ -13,12 +13,10 @@ extern "C" {
 
 #include "group.h"
 #include "ecmult_gen.h"
-#include "util_local_visibility.h"
-
 #ifdef EXHAUSTIVE_TEST_ORDER
 static secp256k1_ge_storage secp256k1_ecmult_gen_prec_table[COMB_BLOCKS][COMB_POINTS];
 #else
-SECP256K1_LOCAL_VAR const secp256k1_ge_storage secp256k1_ecmult_gen_prec_table[COMB_BLOCKS][COMB_POINTS];
+extern const secp256k1_ge_storage secp256k1_ecmult_gen_prec_table[COMB_BLOCKS][COMB_POINTS];
 #endif /* defined(EXHAUSTIVE_TEST_ORDER) */
 
 #ifdef __cplusplus

diff --git a/src/util_local_visibility.h b/src/util_local_visibility.h