bitcoin-core: Migrate to CMake #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
pushed a commit
that referenced
this pull request
Feb 4, 2024
Base PR apache/brpc#2420 ; NOTE: I can't enable memory sanitizer due to ```log BAD BUILD: /tmp/not-out/tmpmptlk01q/fuzz_esp seems to have either startup crash or exit: /tmp/not-out/tmpmptlk01q/fuzz_esp -rss_limit_mb=2560 -timeout=25 -seed=1337 -runs=4 < /dev/null Uninitialized bytes in MemcmpInterceptorCommon at offset 15 inside [0x7030000000f0, 19) ==428==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x682b90 in __interceptor_memcmp /src/llvm-project/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:892:10 #1 0x7fa8ef4cf62a in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::FindLastLessOrEqual(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x15062a) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) #2 0x7fa8ef4d259f in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::AddSymbol(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::pair<void const*, int>) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x15359f) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) #3 0x7fa8ef4d2a15 in google::protobuf::SimpleDescriptorDatabase::DescriptorIndex<std::pair<void const*, int> >::AddFile(google::protobuf::FileDescriptorProto const&, std::pair<void const*, int>) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x153a15) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) #4 0x7fa8ef4cebef in google::protobuf::EncodedDescriptorDatabase::Add(void const*, int) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x14fbef) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) #5 0x7fa8ef499f43 in google::protobuf::DescriptorPool::InternalAddGeneratedFile(void const*, int) (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x11af43) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) #6 0x7fa8ef49281d in protobuf_google_2fprotobuf_2fapi_2eproto::AddDescriptorsImpl() (/tmp/not-out/tmpmptlk01q/lib/libprotobuf.so.17+0x11381d) (BuildId: 64affeb0f489ae4bcea211ed99e1eca15ff97d68) ``` Signed-off-by: Arjun Singh <[email protected]>
hebasto
force-pushed
the
240119-cmake-rebased-82
branch
6 times, most recently
from
62ac9c3 to
21cab1f
Compare
hebasto
force-pushed
the
240119-cmake-rebased-82
branch
from
21cab1f to
23e34d6
Compare
hebasto
force-pushed
the
240119-cmake-rebased-82
branch
from
23e34d6 to
1410de8
Compare
hebasto
pushed a commit
that referenced
this pull request
Nov 20, 2024
A recent upgrade of Envoy' abseil library (envoyproxy/envoy#36317) enabled `layering_check` ([imported commit](abseil/abseil-cpp@143e983#diff-8498e61ae6ae818e1ee9bcefffd37b44a3a596e63d1de03c58087299ccbe7a22)) when building abseil (as part of Envoy). Here's an example of the failure during the build: ``` �[1A�[K�[31m�[1mERROR: �[0m/root/.cache/bazel/_bazel_root/4e9824db8e7d11820cfa25090ed4ed10/external/com_google_absl/absl/types/BUILD.bazel:178:11: Compiling absl/types/bad_variant_access.cc failed: undeclared inclusion(s) in rule '@com_google_absl//absl/types:bad_variant_access': Step #3 - "compile-honggfuzz-address-x86_64": this rule is missing dependency declarations for the following files included by 'absl/types/bad_variant_access.cc': Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/core_headers.cppmap' Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/atomic_hook.cppmap' Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/errno_saver.cppmap' Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-fastbuild-ST-74a21d80f561/bin/external/com_google_absl/absl/base/log_severity.cppmap' ``` Seems that this was encountered in the OSS-Fuzz abseil build and it was patched to disable layering check google#11325: https://github.com/google/oss-fuzz/blob/f0fa8b5cd3f99b5905e91b336d07a870ca1bc2e3/projects/abseil-cpp/build.sh#L17-L21 This PR introduces the same change in Envoy's abseil build. Signed-off-by: Adi Suissa-Peleg <[email protected]>
hebasto
pushed a commit
that referenced
this pull request
Jan 24, 2025
Fixes a build issue: ``` �[1A�[K�[31m�[1mERROR: �[0m/root/.cache/bazel/_bazel_root/4e9824db8e7d11820cfa25090ed4ed10/external/com_google_absl/absl/types/BUILD.bazel:178:11: Compiling absl/types/bad_variant_access.cc [for tool] failed: undeclared inclusion(s) in rule '@@com_google_absl//absl/types:bad_variant_access': Step #3 - "compile-honggfuzz-address-x86_64": this rule is missing dependency declarations for the following files included by 'absl/types/bad_variant_access.cc': Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-opt-exec-ST-13d3ddad9198/bin/external/com_google_absl/absl/base/core_headers.cppmap' Step #3 - "compile-honggfuzz-address-x86_64": 'bazel-out/k8-opt-exec-ST-13d3ddad9198/bin/external/com_google_absl/absl/base/atomic_hook.cppmap' ``` This seems to be due to an issue in bazel: bazelbuild/bazel#23681 The current fix follows the abseil-cpp fuzz fix: google#12858 Signed-off-by: Adi Suissa-Peleg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.