cmake: Add a native build job on Ubuntu 20.04 + CMake 3.16 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
force-pushed
the
231214-cmake-AL
branch
4 times, most recently
from
6771734 to
b2866be
Compare
|
|
||
| include(CTest) | ||
|
|
||
| if(TARGET bitcoin-util AND TARGET bitcoin-tx) | ||
| if(TARGET bitcoin-util AND TARGET bitcoin-tx AND PYTHON_COMMAND) |
There was a problem hiding this comment.
Should there be a warning or something if there is no PYTHON_COMMAND?
|
|
||
| - name: Remove preinstalled CMake | ||
| run: | | ||
| sudo rm /usr/local/bin/cmake /usr/local/bin/ctest |
There was a problem hiding this comment.
Is this something that comes with the github actions image? I do not have this package when I do:
docker pull ubuntu:20.04
docker run -ti --rm ubuntu:20.04 /bin/bash
There was a problem hiding this comment.
Is this something that comes with the github actions image?
It is.
hebasto
force-pushed
the
231214-cmake-AL
branch
from
b2866be to
a054e0b
Compare
Add python-based tests only when PYTHON_COMMAND is available.
Running for pushes is enough in the cmake-staging branch.
Add a native build job on Ubuntu 20.04 that includes the minimum required CMake 3.16.
Fix "Cache save failed." warning.
Add "Install" steps
hebasto
force-pushed
the
231214-cmake-AL
branch
from
207b5fc to
53cb2c8
Compare
|
Thank you for your review! Your comments have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ALLOW_HOST_PACKAGESdepends feature.