cmake: Drop extraneous -fvisibility-inlines-hidden

[hebasto]

This PR mirrors the master branch behavior and addresses bitcoin#30454 (comment).

[m3dwards]

ACK 4dd3928

Straightforward enough. Test on Aarch Mac.

[fanquake]

How did this end up getting added in the first place?

[hebasto]

How did this end up getting added in the first place?

It was added in #32.

[fanquake]

It was added in #32.

Right, my question was why? It's odd that if it was done on purpose, it'd just be removed with 0 explanation, because if there was a reason, then a PR to master with the same justification would be made. Otherwise, I was wondering why it was added.

[hebasto]

It was added in #32.

Right, my question was why?

I don't remember almost a year old staff.

It's odd that if it was done on purpose, it'd just be removed with 0 explanation, because if there was a reason, then a PR to master with the same justification would be made. Otherwise, I was wondering why it was added.

Whatever the initial purpose was, "to mirror the master branch behavior" sounds like an explanation for removal, no?

[theuni]

It was probably added because the two visibility options get set together: both on or both off. @hebasto probably just assumed that logic at the time.

Might be worth a PR to add it to master rather than removing it here.