cmake: Improve Boost checks #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It addresses @fanquake's concerns:
|
fanquake
reviewed
Jun 6, 2024
cmake/module/AddBoostIfNeeded.cmake
Outdated
| #include <boost/test/unit_test.hpp> | ||
| " HAVE_BOOST_UNIT_TEST_H | ||
| ) | ||
| check_include_file_cxx(boost/test/unit_test.hpp HAVE_BOOST_UNIT_TEST_H) |
There was a problem hiding this comment.
I think I might be missing something, but this is still checking two headers.
There was a problem hiding this comment.
Thanks! Reworked.
Only one Boost.Test header is being checked now.
hebasto
force-pushed
the
240606-cmake-FW
branch
2 times, most recently
from
fa5c6c0 to
daca415
Compare
fanquake
reviewed
Jun 10, 2024
cmake/module/AddBoostIfNeeded.cmake
Outdated
| #include <boost/test/included/unit_test.hpp> | ||
| " HAVE_BOOST_INCLUDED_UNIT_TEST_H | ||
| ) | ||
| # Some package managers, such as vcpkg, install Boost headers individually |
There was a problem hiding this comment.
Suggested change
| # Some package managers, such as vcpkg, install Boost headers individually | |
| # Some package managers, such as vcpkg, vendor Boost Test separately | |
| # from the rest of the headers, so we have to check for it individually. |
Add vcpkg-specific comment.
Switch to `check_include_file_cxx` when checking headers. This speeds up configuration. Only one Boost.Test header is being checked now.
fanquake
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit was requested offline.
The second commit speeds up configuration.