cmake: Build libbitcoinkernel and bitcoin-chainstate
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @TheCharlatan @fanquake @theuni @vasild @m3dwards @pablomartin4btc :) |
16 tasks
TheCharlatan
reviewed
Apr 1, 2024
| # incrementally define what to export from the library. | ||
| set_target_properties(bitcoinkernel PROPERTIES | ||
| CXX_VISIBILITY_PRESET default | ||
| ) |
There was a problem hiding this comment.
We currently copy the library to an install directory when running make install, but it seems to be missing in the install dir here.
diff --git a/src/kernel/CMakeLists.txt b/src/kernel/CMakeLists.txt
index cc0263ce3c..620a31134d 100644
--- a/src/kernel/CMakeLists.txt
+++ b/src/kernel/CMakeLists.txt
@@ -108,0 +109,4 @@ set_target_properties(bitcoinkernel PROPERTIES
+
+install(TARGETS bitcoinkernel
+ LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+)
Co-authored-by: TheCharlatan <[email protected]>
pablomartin4btc
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
tACK f9dc316
Tested on Ubuntu 22.04.
...
Configure summary
=================
Executables:
...
bitcoin-chainstate (experimental) ... OFF
libbitcoinkernel (experimental) ..... OFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New build configuration options:
-DBUILD_KERNEL_LIB-DBUILD_UTIL_CHAINSTATETo build a shared
libbitcoinkernel, one can specify-DBUILD_SHARED_LIBS=ON.