Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define onlyIfUnchanged for ETag support #2

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

heaths
Copy link
Owner

@heaths heaths commented Apr 21, 2020

This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.

This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.
@heaths heaths marked this pull request as ready for review April 23, 2020 06:38
@heaths heaths merged this pull request into issue11052 Apr 23, 2020
@heaths
Copy link
Owner Author

heaths commented Apr 23, 2020

Based on internal comments, we'll proceed further down this route.

@heaths heaths deleted the issue11052-alt branch April 23, 2020 06:38
heaths added a commit that referenced this pull request Apr 28, 2020
This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.
heaths added a commit that referenced this pull request Apr 29, 2020
…ions (Azure#11420)

* Combine MatchConditions and SearchRequestOptions

Fixes Azure#11052

* Redefine ETag properties as Azure.ETag?

Fixes Azure#11385

* Update public APIs

* Define onlyIfUnchanged for ETag support (#2)

This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.

* Update CHANGELOG and public APIs
heaths pushed a commit that referenced this pull request Jan 4, 2021
* Updated version number

* Try #2 on beta.1

* Fixed typo in version number
heaths pushed a commit that referenced this pull request Aug 27, 2021
heaths pushed a commit that referenced this pull request Sep 29, 2021
heaths pushed a commit that referenced this pull request Apr 27, 2023
…nd add test coverage (Azure#34743)

* generated code using autorest

* fix mongo collection functions in Custom/RestorableCosmosDBAccountResource.cs

* Fix breaking changes that coming from the safeflatten

* InAccount restore changes for all api kinds

* resolve build errors and update mongo db inaccount restore tests

* update session records

* resolve build errors after merge conflicts

* regenerated changes using dotnet build /t:GenerateCode

* update default values

* fix test with default identity

* updated with eng\scripts\CodeChecks.ps1 -ServiceDirectory cosmosdb

* update sesion records for failing pipeline

* update sesion records for failing pipeline

* update inaccount restore tests to use static time and session records for table and gremlin tests

* Update recording

* Update recording

* update session records for sql and mongo and disable mongo inaccount restore tests

* update generated files with latest

* updated test case for burst capacity

* update session records for database account operations

* updated test case to not enable burst capacity in account creation (#2)

* recorded all tests in DatabaseAccount (#3)

* updated test case to not enable burst capacity in account creation

* recorded all tests in DatabaseAccount

* session recordings of DatabaseAccountTests

* cross region restore updated test

* test recordings update

* updated recordings

* added new group cross region restore

* udpated recordings with playback verification

* updated RestorabledatabaseAccountTests groupo

* update session records for private end point tests

* Rename BackupResource to CassandraClusterBackupResource

* Update API

* update changelog for new sdk release

---------

Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: Wei Hu <[email protected]>
Co-authored-by: Richa Sharma <[email protected]>
Co-authored-by: Richa Sharma <[email protected]>
Co-authored-by: dsapaliga <[email protected]>
heaths pushed a commit that referenced this pull request Jul 6, 2023
…leSnippets.cs. (Azure#37422)

* Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source.

* Fixing missing double quote on region identifier.

* Updating sample C# snippets and code (#2)

* Updating sample C# snippets and code.

* Use explicit type instead of var, remove blank lines from #if

* Finished change to use explicit type instead of var

---------

Co-authored-by: Rango Meadows <[email protected]>

---------

Co-authored-by: Rango Meadows <[email protected]>
Co-authored-by: Michal Materna <[email protected]>
heaths pushed a commit that referenced this pull request Sep 14, 2023
…re#38386)

* Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source.

* Fixing missing double quote on region identifier.

* Updating sample C# snippets and code (#2)

* Updating sample C# snippets and code.

* Use explicit type instead of var, remove blank lines from #if

* Finished change to use explicit type instead of var

---------

Co-authored-by: Rango Meadows <[email protected]>

* Replace async samples with synchronous code

* Corrected reference to async samples in README.md

---------

Co-authored-by: Rango Meadows <[email protected]>
Co-authored-by: Michal Materna <[email protected]>
heaths pushed a commit that referenced this pull request Jan 2, 2024
* Update autorest.md file with latest swagger and allow model duplication

* Generate and upgrade sdk code

* Customize redis common configuration code to include aad-enabled

* Regenerate API file

* Customize redis common configuration code to include aad-enabled

* Mitigate breaking change

* Create empty test-resources.json

* Create FlushFunctionalTests.cs

* Update assets.json

* Add functional tests for aad (#2)

Adds functional tests for aad

* Update Channel Tests (#3)

* Oscarba/fix (#4)

* Update Channel Tests

* Update correct data type

* Push regenerated code

* UpdateChannelFix (#5)

* Update Channel Tests

* Update correct data type

* Update test

* Update tag for assets after push for recordings

* Address reviewer comments

* Update generatred code after mergin in main

* Update FTs for updated models

* Update AAD FT

* Update assets.json

* Update changelog

---------

Co-authored-by: Kanchan Joshi <[email protected]>
Co-authored-by: Austin Tolani <[email protected]>
Co-authored-by: Oscar Barbosa Aquino <[email protected]>
heaths pushed a commit that referenced this pull request May 7, 2024
* Update Generator Version 3.0.0-beta.20240404.1

* Update SDK codes he_mi_3

* Update SDK codes de_he_2

* Update SDK codes ad_co_0

* Update SDK codes sq_wo_6

* Update SDK codes mi_pu_4

* Update SDK codes pu_sq_5

* Update SDK codes co_de_1

* Build fix

* Build fix #2

* Build fix #3

---------

Co-authored-by: Alexander Sher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant