Support to date, datetime and time inputs. #935
Conversation
I changed `DateTimeInput` to support the new HTML5 form helpers that comes with Rails 4 (`date_input`, `datetime_input` and `time_input`) instead of rendering datetime selects: For example, this input: ```erb <%= f.input :born_on, as: :date %> ``` Will render: ```html <input id="user_born_on" name="user[born_on]" type="date" /> ``` Datetime selects are still present, but only when HTML5 compatibility is disabled. It's also possible to render selects even with HTML5 on, by setting the `html5` option to false. If we wanted to use an old date select on the example above, we should do: ```erb <%= f.input :born_on, as: :date, html5: false %> ``` Closes #844.
| @@ -1,8 +1,14 @@ | |||
| module SimpleForm | |||
| module Inputs | |||
| class DateTimeInput < Base | |||
| enable :html5 | |||
There was a problem hiding this comment.
Why do we need to enable html5 here?
|
This will be a lot non backward compatible, but I wonder if we can make it more opt-in instead of opt-out. @nashby @carlosantoniodasilva any ideas? |
Conflicts: CHANGELOG.md
|
@rafaelfranca yeah, I agree with opt-in. I would make |
|
@rafaelfranca @nashby Agreed. Datetime selects are now the default again. |
| @@ -19,6 +23,14 @@ def label_target | |||
| position = ActionView::Helpers::DateTimeSelector::POSITION[position] | |||
| "#{attribute_name}_#{position}i" | |||
| end | |||
|
|
|||
| def use_html5_inputs? | |||
| if input_options.key?(:html5) | |||
There was a problem hiding this comment.
just input_options[:html5] should be enough here.
|
I'm happy to bring html5 date/time fields to Simple Form, however I'm kinda afraid this will bring us issues with people upgrading. Think about this scenario: I have html5 enabled and I'm happy with the current date/time selects, because the other (html5) tags were/are not currently well supported. After upgrading Simple Form, all my date/time fields are going to magically start using the new html5 tags because we changed to rely on the html5 flag (which is enabled in my app due to the other features I wanted). Perhaps we should do it the other way around, be opt-in for these? Maybe we should provide a "migration configuration option" so that you can disable the date/time specific html5 fields instead of having to go figure the places you must pass in html5? Maybe we should provide a warning message or whatever to aid people migrating? We have a couple solutions, not sure what's best, but I'd prefer not to have my inputs changed due to a Simple Form update. And great work here 👍 |
|
@carlosantoniodasilva Following @nashby's suggestion, In my last commits I've changed these inputs to render the new tags only when |
|
@volmer since it will not be the default we need to change the mapping table to point to date select again. |
|
@rafaelfranca The mapping table was not changed, since the input class is the same. |
|
@rafaelfranca Ah, got it. You mean the |
|
@rafaelfranca Done. |
|
This seems good to me. Needs a rebase |
Conflicts: CHANGELOG.md
|
is this feature avaible yet on the master branch? |
|
@pablocrivella not yet. @carlosantoniodasilva @nashby @lucasmazza is this good to go? |
|
|
|
👍 |
Support to date, datetime and time inputs.
I changed
DateTimeInputto support the new HTML5 form helpers that comes with Rails 4 (date_input,datetime_inputandtime_input) instead of rendering datetime selects, by explicitly passing thehtml5option.For example, this input:
Will render something like:
Classic datetime selects are still present for cases when the
html5option is not passed, in order to keep backwards compatibility.Closes #844.