Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keyword arguments for future compatibility #5175

Closed
wants to merge 1 commit into from
Closed

fix keyword arguments for future compatibility #5175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/support/http_method_compatibility.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class IntegrationTest < ActionDispatch::IntegrationTest
if options.empty?
super url
else
super url, options
super url, **options
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only Rails 5+ are required to cope with Ruby2.7 and above (no need to change below part)

end
end
else
Expand All @@ -36,7 +36,7 @@ class ControllerTestCase < ActionController::TestCase
if options.empty?
super action
else
super action, options
super action, **options
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, only Rails5.x and above are required to adapt to Ruby2.7+

end
end
else
Expand Down