Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should include more tests to verify functionality #337

Closed
carlhiggs opened this issue Jul 4, 2023 · 0 comments
Closed

Should include more tests to verify functionality #337

carlhiggs opened this issue Jul 4, 2023 · 0 comments

Comments

@carlhiggs
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently when merging pull requests a Github Actions workflow pulls the Docker image and tests loading the project setup script (subprocesses/ghsci.py).

Describe the solution you'd like
More tests should be run, to confirm the example workflow runs as intended following changes.

This should be relatively straightforward now that the workflow can be run programmatically in Python, so could be evaluated across a series of unit tests.

carlhiggs added a commit that referenced this issue Jul 4, 2023
….4.5, and Docker image) to address #336 and updated test.py to address #337
@carlhiggs carlhiggs mentioned this issue Jul 4, 2023
carlhiggs added a commit that referenced this issue Jul 4, 2023
…worked fine on local computer, but in GitHub Actions workflow, I think it failed as tests were attempted in parallel)
carlhiggs added a commit that referenced this issue Jul 4, 2023
…kflow to work (this is a backstep for #337, but I want to merge the changes so don't want this to hold things up)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant