remove wrong types from ops

headtr1ck · Sep 20, 2023 · ed8d936 · ed8d936
1 parent 6e62ae4
commit ed8d936
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/xarray/core/types.py b/xarray/core/types.py
@@ -38,7 +38,6 @@
     from xarray.core.coordinates import Coordinates
     from xarray.core.dataarray import DataArray
     from xarray.core.dataset import Dataset
-    from xarray.core.groupby import DataArrayGroupBy, GroupBy
     from xarray.core.indexes import Index, Indexes
     from xarray.core.utils import Frozen
     from xarray.core.variable import Variable
@@ -163,8 +162,8 @@ def copy(
 
 ScalarOrArray = Union["ArrayLike", np.generic, np.ndarray, "DaskArray"]
 VarCompatible = Union["Variable", "ScalarOrArray"]
-DaCompatible = Union["DataArray", "DataArrayGroupBy", "VarCompatible"]
-DsCompatible = Union["Dataset", "GroupBy", "DaCompatible"]
+DaCompatible = Union["DataArray", "VarCompatible"]
+DsCompatible = Union["Dataset", "DaCompatible"]
 GroupByCompatible = Union["Dataset", "DataArray"]
 
 Dims = Union[str, Iterable[Hashable], "ellipsis", None]

diff --git a/xarray/tests/test_groupby.py b/xarray/tests/test_groupby.py
@@ -812,7 +812,7 @@ def test_groupby_math_more() -> None:
     with pytest.raises(TypeError, match=r"only support binary ops"):
         grouped + grouped  # type: ignore[operator]
     with pytest.raises(TypeError, match=r"in-place operations"):
-        ds += grouped
+        ds += grouped  # type: ignore[arg-type]
 
     ds = Dataset(
         {