Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: Handle Non JSON errors in response #32

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Mar 14, 2024

this patch handles the Non JSON errors that
are thrown by the k8s proxy when the pod isn't
in Ready state.

prometheus/src/request.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Santhosh, some suggestions :-)

prometheus/src/request.tsx Show resolved Hide resolved
prometheus/src/request.tsx Show resolved Hide resolved
this patch handles the Non JSON errors that
are thrown by the k8s proxy when the pod isn't
in Ready state.

Signed-off-by: yolossn <[email protected]>
@yolossn yolossn force-pushed the handle_error_prometheus branch from 229d74f to c94c947 Compare March 14, 2024 13:34
@yolossn yolossn merged commit 8dfb7bd into main Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants